The self-checkin page was missed in the opac css update. See bug 22274 for self-checkout.
Created attachment 87708 [details] modified: koha-tmpl/opac-tmpl/bootstrap/css/sci.css modified: koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt Bug 22638: Self checkin CSS update This patch updates the Self-Checkin CSS to match tne new OPAC design.
Created attachment 87710 [details] [review] Bug 22638: Self checkin CSS update This patch updates the Self-Checkin CSS to match tne new OPAC design.
Created attachment 87767 [details] [review] Bug 22638: (follow-up) Convert SCI CSS to SCSS This patch makes a number of follow-up changes, including: - Covert remaining icons to Font Awesome - Convert CSS to SCSS - Move SCSS which is common to both the OPAC and SCI into separate files to be including in each during compilation. - Make minor correction to opac.scss to fix SCSS build warning To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable the self checkin module using using the SelfCheckInModule system preference. - Open the self checkin interface and test the checkin process. Everything should look correct. - After submitting barcodes for checkin, the "Finish" button should show a Font Awesome icon instead of an image icon. - Enable multiple translations and set the OpacLangSelectorMode preference to show the language menu in the footer. - Confirm that the language menu looks correct. - View the regular OPAC to make sure the changes to opac.scss didn't result in unintended changes to the interface.
Created attachment 87769 [details] [review] Bug 22638: Self checkin CSS update This patch updates the Self-Checkin CSS to match tne new OPAC design. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 87770 [details] [review] Bug 22638: (follow-up) Convert SCI CSS to SCSS This patch makes a number of follow-up changes, including: - Covert remaining icons to Font Awesome - Convert CSS to SCSS - Move SCSS which is common to both the OPAC and SCI into separate files to be including in each during compilation. - Make minor correction to opac.scss to fix SCSS build warning To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable the self checkin module using using the SelfCheckInModule system preference. - Open the self checkin interface and test the checkin process. Everything should look correct. - After submitting barcodes for checkin, the "Finish" button should show a Font Awesome icon instead of an image icon. - Enable multiple translations and set the OpacLangSelectorMode preference to show the language menu in the footer. - Confirm that the language menu looks correct. - View the regular OPAC to make sure the changes to opac.scss didn't result in unintended changes to the interface.
Hi Owen, I tried to test the patches on our local test system and a number of hunks didn't apply. What's the baseline version for the patches? I'm on 18.11.04. Cheers
Hi Oliver, patches are always created and have to be applied against the most recent master branch (http://git.koha-community.org/gitweb/?p=koha.git;a=shortlog;h=refs/heads/master) as it will be applied there and then backported into older versions if it's a bugfix or minor enhancement.
I did a first test: I forgot the CSS language bar at the bottom and the Font needs to be added in.
Apart from the missing language menu (see Claire's previous comment) everything looks fine to me (tested on ByWater sandbox as most others didn't work for me).
(In reply to Claire Gravely from comment #8) > I did a first test: > > I forgot the CSS language bar at the bottom and the Font needs to be added > in. Nope, it is all looking good, font and style is there! Sorry!
Ok, so I don't know how to "Enable multiple translations" in a sandbox (the I18N admin prefs don't allow adding languages), so I'd trust Claire's assessment. What I noticed in Firefox is: 1) The "Powered by Koha" footer string is left-adjusted, instead of right-adjusted like the OPAC 2) The font size and style for the SCI top menu is different from the OPAC, which shows if you switch between the two. The SCI header uses a smaller font and has a (ugly) drop-shadow, compared to the OPAC's header (preferred!). HTH
(In reply to Oliver Behnke from comment #11) > 1) The "Powered by Koha" footer string is left-adjusted, instead of > right-adjusted like the OPAC Confirmed. > 2) The font size and style for the SCI top menu is different from the OPAC, > which shows if you switch between the two. I don't find this to be the case. Did you clear your browser cache after rebuilding the CSS?
Hm, good point. How do I rebuild the CSS (from SCSS I suppose) in a sandbox?
(In reply to Oliver Behnke from comment #13) > Hm, good point. How do I rebuild the CSS (from SCSS I suppose) in a sandbox? Sorry I didn't think about the sandbox testing process... I don't think you can use a sandbox to test a patch which requires rebuilding CSS.
Makes sense. So that leaves Claire to sign-off if she can't reproduce the front style/size issue I mentioned. Maybe after you moved the string to the right :-) Cheers
Created attachment 88086 [details] [review] Bug 22638: (follow-up) Convert SCI CSS to SCSS This patch makes a number of follow-up changes, including: - Covert remaining icons to Font Awesome - Convert CSS to SCSS - Move SCSS which is common to both the OPAC and SCI into separate files to be including in each during compilation. - Make minor correction to opac.scss to fix SCSS build warning To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable the self checkin module using using the SelfCheckInModule system preference. - Open the self checkin interface and test the checkin process. Everything should look correct. - After submitting barcodes for checkin, the "Finish" button should show a Font Awesome icon instead of an image icon. - Enable multiple translations and set the OpacLangSelectorMode preference to show the language menu in the footer. - Confirm that the language menu looks correct. - View the regular OPAC to make sure the changes to opac.scss didn't result in unintended changes to the interface.
Created attachment 88087 [details] [review] Bug 22638: Self checkin CSS update This patch updates the Self-Checkin CSS to match tne new OPAC design. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 88088 [details] [review] Bug 22638: (follow-up) Convert SCI CSS to SCSS This patch makes a number of follow-up changes, including: - Covert remaining icons to Font Awesome - Convert CSS to SCSS - Move SCSS which is common to both the OPAC and SCI into separate files to be including in each during compilation. - Make minor correction to opac.scss to fix SCSS build warning To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable the self checkin module using using the SelfCheckInModule system preference. - Open the self checkin interface and test the checkin process. Everything should look correct. - After submitting barcodes for checkin, the "Finish" button should show a Font Awesome icon instead of an image icon. - Enable multiple translations and set the OpacLangSelectorMode preference to show the language menu in the footer. - Confirm that the language menu looks correct. - View the regular OPAC to make sure the changes to opac.scss didn't result in unintended changes to the interface. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 88110 [details] [review] Bug 22638: Self checkin CSS update This patch updates the Self-Checkin CSS to match tne new OPAC design. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 88111 [details] [review] Bug 22638: (follow-up) Convert SCI CSS to SCSS This patch makes a number of follow-up changes, including: - Covert remaining icons to Font Awesome - Convert CSS to SCSS - Move SCSS which is common to both the OPAC and SCI into separate files to be including in each during compilation. - Make minor correction to opac.scss to fix SCSS build warning To test, apply the patch and rebuild the OPAC CSS. Clear your browser cache if necessary. - Enable the self checkin module using using the SelfCheckInModule system preference. - Open the self checkin interface and test the checkin process. Everything should look correct. - After submitting barcodes for checkin, the "Finish" button should show a Font Awesome icon instead of an image icon. - Enable multiple translations and set the OpacLangSelectorMode preference to show the language menu in the footer. - Confirm that the language menu looks correct. - View the regular OPAC to make sure the changes to opac.scss didn't result in unintended changes to the interface. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Thanks everyone for getting this done. Hopefully future OPAC CSS changes will include tests of the SCI/SCO modules as well :-) Cheers!
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.