| Summary: | Circulation.t noisy since Bug 21753 was pushed | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Test Suite | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 21753 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 22374: Silence warning in UpdateFine logaction
Bug 22374: Silence warning in UpdateFine logaction Bug 22374: Silence warning in UpdateFine logaction |
||
|
Description
Martin Renvoize (ashimema)
2019-02-20 09:20:01 UTC
Created attachment 85318 [details] [review] Bug 22374: Silence warning in UpdateFine logaction In bug 21753 we replaced the always empty variable $type with undef and this caused noise in the Circulation.t tests. This patch replaces the undef with the string 'UPDATE' to reflact that fine updates are taking place. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 85451 [details] [review] Bug 22374: Silence warning in UpdateFine logaction In bug 21753 we replaced the always empty variable $type with undef and this caused noise in the Circulation.t tests. This patch replaces the undef with the string 'UPDATE' to reflact that fine updates are taking place. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> *** Bug 22356 has been marked as a duplicate of this bug. *** Created attachment 85651 [details] [review] Bug 22374: Silence warning in UpdateFine logaction In bug 21753 we replaced the always empty variable $type with undef and this caused noise in the Circulation.t tests. This patch replaces the undef with the string 'UPDATE' to reflact that fine updates are taking place. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 21747 removed this code, is this still needed? |