Description
Marjorie Barry-Vila
2019-02-25 19:22:32 UTC
Hi Marjorie, thx for reporting! By default new bugs get 'enhancement' - please feel free to change that setting for bugs! (In reply to Katrin Fischer from comment #1) > Hi Marjorie, thx for reporting! By default new bugs get 'enhancement' - > please feel free to change that setting for bugs! Ok thanks! Marjorie Created attachment 86049 [details] [review] Bug 22413: Improve query string and desc creation for Elasticsearch Test plan: After each of the following steps, verify that the results and query description looks ok. 1. Do a simple keyword query 2. Change sort order 3. Click a facet 4. Do an advanced search with title and author 5. Change sort order 6. Click a facet Created attachment 86059 [details] [review] Bug 22413: Improve query string and desc creation for Elasticsearch Test plan: After each of the following steps, verify that the results and query description looks ok. 1. Do a simple keyword query 2. Change sort order 3. Click a facet 4. Do an advanced search with title and author 5. Change sort order 6. Click a facet Signed-off-by: Josef Moravec <josef.moravec@gmail.com> *** Bug 18319 has been marked as a duplicate of this bug. *** Patch tested with a sandbox, by Marjorie <marjorie.barry-vila@collecto.ca> Created attachment 87026 [details] [review] Bug 22413: Improve query string and desc creation for Elasticsearch Test plan: After each of the following steps, verify that the results and query description looks ok. 1. Do a simple keyword query 2. Change sort order 3. Click a facet 4. Do an advanced search with title and author 5. Change sort order 6. Click a facet Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marjorie <marjorie.barry-vila@collecto.ca> Sorry Ere, I had a quick go at re-basing this but I wasn't entirely confident I was getting it right. Setting to Does Not Apply, once rebased please set back to SO and I'll get back to QAing it. Created attachment 88716 [details] [review] Bug 22413: Improve query string and desc creation for Elasticsearch Test plan: After each of the following steps, verify that the results and query description looks ok. 1. Do a simple keyword query 2. Change sort order 3. Click a facet 4. Do an advanced search with title and author 5. Change sort order 6. Click a facet Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marjorie <marjorie.barry-vila@collecto.ca> Rebased. I also sneaked in a tweak to exclude any limits from the displayed query since they're displayed separately. Created attachment 88733 [details] [review] Bug 22413: Improve query string and desc creation for Elasticsearch Test plan: After each of the following steps, verify that the results and query description looks ok. 1. Do a simple keyword query 2. Change sort order 3. Click a facet 4. Do an advanced search with title and author 5. Change sort order 6. Click a facet Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marjorie <marjorie.barry-vila@collecto.ca> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Awesome, works well and no regressions found. Passing QA Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.05 *** Bug 20114 has been marked as a duplicate of this bug. *** *** Bug 22412 has been marked as a duplicate of this bug. *** |