| Summary: | Entries missing in koha-conf.xml | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | dcook, fridolin.somers, m.de.rooy, magnus, martin.renvoize, mtompset, nick, tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31059 |
||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.05
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 26253, 26260 | ||
| Attachments: |
Bug 22857: Sync koha-conf.xml files
Bug 22857: Sync koha-conf.xml files Bug 22857: Sync koha-conf.xml files Bug 22857: (QA follow-up) Cosmetic changes: typo, whitespace |
||
|
Description
Jonathan Druart
2019-05-06 19:04:28 UTC
And debian/templates/koha-conf-site.xml.in? Agreed. Created attachment 95045 [details] [review] Bug 22857: Sync koha-conf.xml files Missing entries are added to those files. Test plan: Search for typos Compare the two files and comfirm the entries are the same in both. Exception: supportdir exists in etc/koha-conf.xml only, but I think it's obsolete. Created attachment 95048 [details] [review] Bug 22857: Sync koha-conf.xml files Missing entries are added to those files. Test plan: Search for typos Compare the two files and comfirm the entries are the same in both. Exception: supportdir exists in etc/koha-conf.xml only, but I think it's obsolete. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Reads well, just wondering if this could cause problems being there by default when not using the Let's encrypt feature provided by Koha for your certs? + <tls>__DB_USE_TLS__</tls> + <ca>__DB_TLS_CA_CERTIFICATE__</ca> + <cert>__DB_TLS_CLIENT_CERTIFICATE__</cert> + <key>__DB_TLS_CLIENT_KEY__</key> (In reply to Katrin Fischer from comment #5) > Reads well, just wondering if this could cause problems being there by > default when not using the Let's encrypt feature provided by Koha for your > certs? > > + <tls>__DB_USE_TLS__</tls> > + <ca>__DB_TLS_CA_CERTIFICATE__</ca> > + <cert>__DB_TLS_CLIENT_CERTIFICATE__</cert> > + <key>__DB_TLS_CLIENT_KEY__</key> This is stuff from an older 'feature': commit 84e48d03238ce2446e7ea24401bda0a8f4e4422d Author: Dimitris Kamenopoulos <dkamen@gmail.com> Date: Sun Dec 27 16:01:43 2015 +1300 if( $self->{'tls'} && $self->{'tls'} eq 'yes' ) {
=> if tls == __DB_USE_TLS_ (since it was not replaced by koha-create), the condition still works
=> But I could imagine that we should want to comment it
Created attachment 95184 [details] [review] Bug 22857: Sync koha-conf.xml files Missing entries are added to those files. Test plan: Search for typos Compare the two files and comfirm the entries are the same in both. Exception: supportdir exists in etc/koha-conf.xml only, but I think it's obsolete. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 95185 [details] [review] Bug 22857: (QA follow-up) Cosmetic changes: typo, whitespace Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.05 *** Bug 18245 has been marked as a duplicate of this bug. *** *** Bug 12584 has been marked as a duplicate of this bug. *** |