Bug 18245 - debian/templates/koha-conf-site.xml.in missing tls
Summary: debian/templates/koha-conf-site.xml.in missing tls
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-10 19:56 UTC by M. Tompsett
Modified: 2017-10-24 02:14 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 18245: Add missing TLS to debian/templates/koha-conf-site.xml.in (896 bytes, patch)
2017-03-10 19:59 UTC, M. Tompsett
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description M. Tompsett 2017-03-10 19:56:07 UTC
As noted by Marcel in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427#c17
Comment 1 M. Tompsett 2017-03-10 19:59:45 UTC
Created attachment 61004 [details] [review]
Bug 18245: Add missing TLS to debian/templates/koha-conf-site.xml.in

This was found as a result of testing another bug.
Added missing line.
Comment 2 Mirko Tietgen 2017-03-22 16:23:39 UTC
If you want to add this, I think you also need to add <ca>, <cert> and <key>?
Comment 3 M. Tompsett 2017-04-14 16:04:06 UTC
(In reply to Mirko Tietgen from comment #2)
> If you want to add this, I think you also need to add <ca>, <cert> and <key>?

You may be right, but check out the diff between etc/koha-conf.xml and debian/templates/koha-conf-site.xml/in currently.

I'm not sure the correct way to add, because hard-coded-path/__KOHASITE__/rest-of-path is not the same as __SOME_THING_TO_FULLY_REPLACE__/rest-of-path.

Thoughts?