| Summary: | Remove type attribute from script tags: Staff client includes 2/2 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | hayleypelham, nick, testopia |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22957 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 22974 | ||
| Bug Blocks: | 22956 | ||
| Attachments: |
Bug 22973: Remove type attribute from script tags: Staff client includes 2/2
Bug 22973: Remove type attribute from script tags: Staff client includes 2/2 Bug 22973: Remove type attribute from script tags: Staff client includes 2/2 |
||
|
Description
Owen Leonard
2019-05-23 12:34:04 UTC
Created attachment 90031 [details] [review] Bug 22973: Remove type attribute from script tags: Staff client includes 2/2 This patch removes the "type" attribute from <script> tags in several staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Installer -> Onboarding (uses installer-strings.inc, validator-strings.inc) - Patrons -> Patron details -> Change password (uses password_check.inc) - Patrons -> Patron details -> Print summary (slip-print.inc) - Circulation -> Check out (strings.inc, timepicker.inc) - Cataloging -> New from Z39.50/SRU (z3950_search.inc) Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Created attachment 90055 [details] [review] Bug 22973: Remove type attribute from script tags: Staff client includes 2/2 This patch removes the "type" attribute from <script> tags in several staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Installer -> Onboarding (uses installer-strings.inc, validator-strings.inc) - Patrons -> Patron details -> Change password (uses password_check.inc) - Patrons -> Patron details -> Print summary (slip-print.inc) - Circulation -> Check out (strings.inc, timepicker.inc) - Cataloging -> New from Z39.50/SRU (z3950_search.inc) Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Created attachment 90124 [details] [review] Bug 22973: Remove type attribute from script tags: Staff client includes 2/2 This patch removes the "type" attribute from <script> tags in several staff client include files. Also removed: Obsolete "//<![CDATA[ //]]>" markers. This patch also makes minor indentation changes, so diff using the "-w" flag. To test, apply the patch and confirm that examples of affected pages work properly without any JavaScript errors in the browser console: - Installer -> Onboarding (uses installer-strings.inc, validator-strings.inc) - Patrons -> Patron details -> Change password (uses password_check.inc) - Patrons -> Patron details -> Print summary (slip-print.inc) - Circulation -> Check out (strings.inc, timepicker.inc) - Cataloging -> New from Z39.50/SRU (z3950_search.inc) Validating the HTML source of any of these pages should return no errors related to the "type" attribute. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 |