Summary: | Warning when in Mana KB settings Auto subscription sharing is unchecked | ||
---|---|---|---|
Product: | Koha | Reporter: | Joonas Kylmälä <joonas.kylmala> |
Component: | Mana-kb | Assignee: | Joonas Kylmälä <joonas.kylmala> |
Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, lucas, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.02
|
|
Circulation function: | |||
Attachments: |
0001-Bug-23034-Remove-uninitialized-value-warning-in-Mana
Bug 23034: Remove uninitialized value warning in Mana KB settings Bug 23034: Remove uninitialized value warning in Mana KB settings |
Description
Joonas Kylmälä
2019-06-03 14:53:55 UTC
Created attachment 90273 [details] [review] 0001-Bug-23034-Remove-uninitialized-value-warning-in-Mana Here is a patch to remove the warning. Created attachment 90776 [details] [review] Bug 23034: Remove uninitialized value warning in Mana KB settings This gets rid of the warning "Use of uninitialized value $auto_share in string ne at [...]" by initializing the variable with empty string. Test plan: 1) Go to page cgi-bin/koha/admin/share_content.pl and unselect "Auto subscription sharing". Click "Save". 2) Check plack-error.log and notice the warning "Use of uninitialized value $auto_share [...]" 3) Apply the patch and repeat the previous steps but now this time the warning is gone in plack-error.log. 4) Make sure the AutoShareWithMana syspref with and without the patch is in unselected state after clicking "Save". Sponsored-by: The National Library of Finland Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works well, thanks for the patch. Created attachment 90922 [details] [review] Bug 23034: Remove uninitialized value warning in Mana KB settings This gets rid of the warning "Use of uninitialized value $auto_share in string ne at [...]" by initializing the variable with empty string. Test plan: 1) Go to page cgi-bin/koha/admin/share_content.pl and unselect "Auto subscription sharing". Click "Save". 2) Check plack-error.log and notice the warning "Use of uninitialized value $auto_share [...]" 3) Apply the patch and repeat the previous steps but now this time the warning is gone in plack-error.log. 4) Make sure the AutoShareWithMana syspref with and without the patch is in unselected state after clicking "Save". Sponsored-by: The National Library of Finland Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 Nice work! Pushed to master for 19.11.00 Pushed to 19.05.x for 19.05.02 no backport for 18.11.x |