If you go to the page /cgi-bin/koha/admin/share_content.pl and unselect the checkbox "Auto subscription sharing" you will get following warning to plack-error.log: "Use of uninitialized value $auto_share in string ne at /home/koha/kohaclone/admin/share_content.pl line 49."
Created attachment 90273 [details] [review] 0001-Bug-23034-Remove-uninitialized-value-warning-in-Mana Here is a patch to remove the warning.
Created attachment 90776 [details] [review] Bug 23034: Remove uninitialized value warning in Mana KB settings This gets rid of the warning "Use of uninitialized value $auto_share in string ne at [...]" by initializing the variable with empty string. Test plan: 1) Go to page cgi-bin/koha/admin/share_content.pl and unselect "Auto subscription sharing". Click "Save". 2) Check plack-error.log and notice the warning "Use of uninitialized value $auto_share [...]" 3) Apply the patch and repeat the previous steps but now this time the warning is gone in plack-error.log. 4) Make sure the AutoShareWithMana syspref with and without the patch is in unselected state after clicking "Save". Sponsored-by: The National Library of Finland Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works well, thanks for the patch.
Created attachment 90922 [details] [review] Bug 23034: Remove uninitialized value warning in Mana KB settings This gets rid of the warning "Use of uninitialized value $auto_share in string ne at [...]" by initializing the variable with empty string. Test plan: 1) Go to page cgi-bin/koha/admin/share_content.pl and unselect "Auto subscription sharing". Click "Save". 2) Check plack-error.log and notice the warning "Use of uninitialized value $auto_share [...]" 3) Apply the patch and repeat the previous steps but now this time the warning is gone in plack-error.log. 4) Make sure the AutoShareWithMana syspref with and without the patch is in unselected state after clicking "Save". Sponsored-by: The National Library of Finland Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.02
no backport for 18.11.x