Description
Tomás Cohen Arazi
2019-07-08 17:08:35 UTC
Created attachment 91415 [details] [review] Bug 23281: Add Koha::Objects::Limit::Library Created attachment 91416 [details] [review] Bug 23281: Implement ->search_with_library_limits in Koha::Patron::Attribute::Types This patch makes Koha::Patron::Attribute::Types inherit from Koha::Objects::Limit::Library so it now has the ->search_with_library_limits method. Tests are adjusted so it is clear that there is no behaviour change compared to the (previsouly) called ->search To test: - Run: k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests pass! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests still pass! - Sign off :-D Created attachment 91417 [details] [review] Bug 23281: Cleanup Koha::Patron::Attribute::Types->search Note to testers: Koha::Patron::Attribute::Tyes->search is not actually used in the code. It should be used for getting rid of C4::AttributeTypes. Once we have a clear idea about this patchset, this tasks could be done easily during this release cycle. I have already filed bug 23272 and bug 23271, that would benefit from this dev. Created attachment 91459 [details] [review] Bug 23281: Add Koha::Objects::Limit::Library Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 91460 [details] [review] Bug 23281: Implement ->search_with_library_limits in Koha::Patron::Attribute::Types This patch makes Koha::Patron::Attribute::Types inherit from Koha::Objects::Limit::Library so it now has the ->search_with_library_limits method. Tests are adjusted so it is clear that there is no behaviour change compared to the (previsouly) called ->search To test: - Run: k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests pass! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 91461 [details] [review] Bug 23281: Cleanup Koha::Patron::Attribute::Types->search Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 92337 [details] [review] Bug 23281: Add Koha::Objects::Limit::Library Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 92338 [details] [review] Bug 23281: Implement ->search_with_library_limits in Koha::Patron::Attribute::Types This patch makes Koha::Patron::Attribute::Types inherit from Koha::Objects::Limit::Library so it now has the ->search_with_library_limits method. Tests are adjusted so it is clear that there is no behaviour change compared to the (previsouly) called ->search To test: - Run: k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests pass! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 92339 [details] [review] Bug 23281: Cleanup Koha::Patron::Attribute::Types->search Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work! Pushed to master for 19.11.00 Enhancement not pushed to 19.05.x |