Summary: | Itemtype icons not showing in table | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | System Administration | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | agustinmoyano, fridolin.somers, gmcharlt, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
Circulation function: | |||
Bug Depends on: | 20216, 23602 | ||
Bug Blocks: | |||
Attachments: |
Bug 23772: Revert to passing itemtype objects to the template
Bug 23772: Revert to passing itemtype objects to the template Bug 23772: Revert to passing itemtype objects to the template |
Description
Katrin Fischer
2019-10-07 21:22:19 UTC
Git bisect says the display problem (icons not showing up in the table) is caused by Bug 23602. Git bisect says the problem with the correct icon's radio button not being selected arose way back in Bug 20216. Quite some detective work there! Should we split this into 2 separate bugs then? Created attachment 94011 [details] [review] Bug 23772: Revert to passing itemtype objects to the template This patch restores the methodology prior to bug 23602 of passing the full Koha::ItemType objects to the template and thus giving us the ability to use all the methods present within them. Test plan: 1) Ensure you have at least one itemtype with an assigned icon and the images enabled. 2) View the itemtypes admin page and note the icons display again 3) Ensure you have at least one itemtype with library limitations defined. 4) View the itemtypes admin page and note the library limitations still display. 5) Signoff Created attachment 94016 [details] [review] Bug 23772: Revert to passing itemtype objects to the template This patch restores the methodology prior to bug 23602 of passing the full Koha::ItemType objects to the template and thus giving us the ability to use all the methods present within them. Test plan: 1) Ensure you have at least one itemtype with an assigned icon and the images enabled. 2) View the itemtypes admin page and note the icons display again 3) Ensure you have at least one itemtype with library limitations defined. 4) View the itemtypes admin page and note the library limitations still display. 5) Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 94035 [details] [review] Bug 23772: Revert to passing itemtype objects to the template This patch restores the methodology prior to bug 23602 of passing the full Koha::ItemType objects to the template and thus giving us the ability to use all the methods present within them. Test plan: 1) Ensure you have at least one itemtype with an assigned icon and the images enabled. 2) View the itemtypes admin page and note the icons display again 3) Ensure you have at least one itemtype with library limitations defined. 4) View the itemtypes admin page and note the library limitations still display. 5) Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thx for the fix! Nice work! Pushed to master for 19.11.00 |