Summary: | Auto generate accession number format <branchcode>yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition | ||
---|---|---|---|
Product: | Koha | Reporter: | Abhi <abhishekv> |
Component: | Cataloging | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | major | ||
Priority: | P5 - low | CC: | abhishekv, fridolin.somers, hagud, isabel.pineda, jonathan.druart, m.de.rooy, nengard, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.00,19.05.05
|
|
Circulation function: | |||
Attachments: |
Multiple items added in the catalog, with branchcode missing from barcode prefix
Bug 23851: Add the homebranch prefix to the barcode when adding multiple copies of an items Bug 23851: Add the homebranch prefix to the barcode when adding multiple copies of an items Bug 23851: Add the homebranch prefix to the barcode when adding multiple copies of an items |
Lowering severity. Created attachment 94519 [details] [review] Bug 23851: Add the homebranch prefix to the barcode when adding multiple copies of an items See the comment in the code for more information. Test plan: - Set autoBarcode to hbyymmincr - Create an item and click on the barcode field - A barcode prefixed by the homebranch is generated - Click the "Add multiple copies of this item" and enter 4 - Save => Without this patch only the first item has the homebranch prefix => With this patch applied they all have a barcode in the same format *** Bug 23270 has been marked as a duplicate of this bug. *** *** Bug 4175 has been marked as a duplicate of this bug. *** Created attachment 94974 [details] [review] Bug 23851: Add the homebranch prefix to the barcode when adding multiple copies of an items See the comment in the code for more information. Test plan: - Set autoBarcode to hbyymmincr - Create an item and click on the barcode field - A barcode prefixed by the homebranch is generated - Click the "Add multiple copies of this item" and enter 4 - Save => Without this patch only the first item has the homebranch prefix => With this patch applied they all have a barcode in the same format Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> 3 bugs for the price of one sign-off... a good deal I'd say :) *** Bug 15239 has been marked as a duplicate of this bug. *** Created attachment 95208 [details] [review] Bug 23851: Add the homebranch prefix to the barcode when adding multiple copies of an items See the comment in the code for more information. Test plan: - Set autoBarcode to hbyymmincr - Create an item and click on the barcode field - A barcode prefixed by the homebranch is generated - Click the "Add multiple copies of this item" and enter 4 - Save => Without this patch only the first item has the homebranch prefix => With this patch applied they all have a barcode in the same format Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Katrin Fischer from comment #6) > 3 bugs for the price of one sign-off... a good deal I'd say :) No good deal, this is horrible code ;) Nice work! Pushed to master for 19.11.00 Thanks for this fix! It is present in 18.11 also. Pushed to 19.05.x for 19.05.05 # This is terribly hacky :'( |
Created attachment 94430 [details] Multiple items added in the catalog, with branchcode missing from barcode prefix When selected autoBarcode format to <branchcode>yymm0001 and trying to add multiple items from the item addition form the items get added but the barcode (p - Accession Number) field does not contain branch code prefix and only the 0001 segment gets incremented. This is in case if branchcode is in Char format eg. <BLR>yymm0001