| Summary: | 'Activate filters' untranslatable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
| Component: | I18N/L10N | Assignee: | Maryse Simard <maryse.simard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | 1joynelson, f.demians, fridolin.somers, hayleypelham, jonathan.druart, lucas, martin.renvoize, maryse.simard, oleonard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.02, 19.05.07, 18.11.13
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 22490 | ||
| Attachments: |
Intranet detail page in fr-CA
Bug 24046: Untranslatable 'Activate filters' Bug 24046: Untranslatable 'Activate filters' Bug 24046: Untranslatable 'Activate filters' Bug 24046: Untranslatable 'Activate filters' |
||
Created attachment 95514 [details] [review] Bug 24046: Untranslatable 'Activate filters' Bug 9573 moved the code for the table filters activation to it's own javascript file. The strings contained in this file are not translatable. This patch moves the strings to their own strings file which is then included with the javascript from the templates. Test plan: Visit the catalogue/detail.pl and reports/itemslost.pl and test that the 'Activate/Deactivate filters' option still work correctly. Hi Maryse, I do not think we should have a new include file in str/ I would suggest to have those strings defined in datatables.inc instead, as they are related to dataTable Created attachment 96231 [details] [review] Bug 24046: Untranslatable 'Activate filters' Bug 9573 moved the code for the table filters activation to it's own javascript file. The strings contained in this file are not translatable. This patch moves the strings to the datatables include file since the filters are related to datatables. Test plan: Visit the catalogue/detail.pl and reports/itemslost.pl and test that the 'Activate/Deactivate filters' option still work correctly. (In reply to Jonathan Druart from comment #2) > I would suggest to have those strings defined in datatables.inc instead, as > they are related to dataTable This makes sense. I amended the patch to move the strings to this file. Created attachment 96285 [details] [review] Bug 24046: Untranslatable 'Activate filters' Bug 9573 moved the code for the table filters activation to it's own javascript file. The strings contained in this file are not translatable. This patch moves the strings to the datatables include file since the filters are related to datatables. Test plan: Visit the catalogue/detail.pl and reports/itemslost.pl and test that the 'Activate/Deactivate filters' option still work correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 96291 [details] [review] Bug 24046: Untranslatable 'Activate filters' Bug 9573 moved the code for the table filters activation to it's own javascript file. The strings contained in this file are not translatable. This patch moves the strings to the datatables include file since the filters are related to datatables. Test plan: Visit the catalogue/detail.pl and reports/itemslost.pl and test that the 'Activate/Deactivate filters' option still work correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.02 backported to 19.05.x for 19.05.07 Backported to 18.11.x for 18.11.13 |
Created attachment 95437 [details] Intranet detail page in fr-CA When looking at the intranet detail page, in the holdings tab, there is 'Activate filters' which is untranslatable. I *think* it's because it's in a JS tidbit of code, but I'm not sure... See screenshot of fr-CA detail page with Activate filters in English.