Description
Martin Renvoize (ashimema)
2019-11-21 13:42:48 UTC
Created attachment 97042 [details] [review] Bug 24082: Add a refund option to POS Created attachment 97826 [details] [review] Bug 24082: Add `anonymous_refund` permission to `cash_management` This patch adds the new `anonymous_refund` permission to the `cash_management` flag and binds it to the visability of the register details page. Created attachment 97827 [details] [review] Bug 24082: Add refund action to relevant lines Created attachment 97828 [details] [review] Bug 24082: Add access to historical transactions Created attachment 98849 [details] [review] Bug 24082: Add `anonymous_refund` permission to `cash_management` This patch adds the new `anonymous_refund` permission to the `cash_management` flag and binds it to the visability of the register details page. https://bugs.koha-community.org/show_bug.cgi?id=23355 Created attachment 98850 [details] [review] Bug 24082: Add refund action to relevant lines https://bugs.koha-community.org/show_bug.cgi?id=23355 Created attachment 98851 [details] [review] Bug 24082: Add access to historical transactions https://bugs.koha-community.org/show_bug.cgi?id=23355 Rebased Created attachment 98854 [details] [review] Bug 24082: Add `anonymous_refund` permission to `cash_management` This patch adds the new `anonymous_refund` permission to the `cash_management` flag and binds it to the visability of the register details page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 98855 [details] [review] Bug 24082: Add refund action to relevant lines Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 98856 [details] [review] Bug 24082: Add access to historical transactions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> This bug was actually just split out from bug 23355 which was already signed off by Kyle.. just added his signoff back in as it got lost during the reshuffle to make QA simpler. Created attachment 99983 [details] [review] Bug 24082: Add `anonymous_refund` permission to `cash_management` This patch adds the new `anonymous_refund` permission to the `cash_management` flag and binds it to the visability of the register details page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 99984 [details] [review] Bug 24082: Add refund action to relevant lines Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 99985 [details] [review] Bug 24082: Add access to historical transactions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 99991 [details] [review] Bug 24082: Add `anonymous_refund` permission to `cash_management` This patch adds the new `anonymous_refund` permission to the `cash_management` flag and binds it to the visability of the register details page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 99992 [details] [review] Bug 24082: Add refund action to relevant lines Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 99993 [details] [review] Bug 24082: Add access to historical transactions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 99995 [details] [review] Bug 24082: Add `anonymous_refund` permission to `cash_management` This patch adds the new `anonymous_refund` permission to the `cash_management` flag and binds it to the visability of the register details page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 99996 [details] [review] Bug 24082: Add refund action to relevant lines Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 99997 [details] [review] Bug 24082: Add access to historical transactions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 100031 [details] [review] Bug 24082: Add `anonymous_refund` permission to `cash_management` This patch adds the new `anonymous_refund` permission to the `cash_management` flag and binds it to the visability of the register details page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 100032 [details] [review] Bug 24082: Add refund action to relevant lines Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 100033 [details] [review] Bug 24082: Add access to historical transactions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Works as expected, fixed minor QA issues. Created attachment 100070 [details] [review] Bug 24082: Add `anonymous_refund` permission to `cash_management` This patch adds the new `anonymous_refund` permission to the `cash_management` flag and binds it to the visability of the register details page. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 100071 [details] [review] Bug 24082: Add refund action to relevant lines Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 100072 [details] [review] Bug 24082: Add access to historical transactions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 100073 [details] [review] Bug 24082: (QA follow-up): Template fixes This patch introduces missing TT filters and also replaces tabs for spaces to fix indentation problems. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Nice work everyone! Pushed to master for 20.05 not pushed to 19.11.x due to dependencies |