Created attachment 97824 [details] [review]
Bug 24492: Add branch details page

This patch adds a new 'branch details' page to the POS system which
displays a summary of the cash register transactions for a branch
since each register was last cashed up. It also allows for cashing
up individual registers or cashing up all registers at a given branch
in one transaction.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Created attachment 98019 [details] [review]
Bug 24492: Add branch details page

This patch adds a new 'branch details' page to the POS system which
displays a summary of the cash register transactions for a branch
since each register was last cashed up. It also allows for cashing
up individual registers or cashing up all registers at a given branch
in one transaction.

1) Enable the point of sale feature (EnablePointOfSale + UseCashRegister system preferences)
2) Add a cash register for a library (Home > Point of sale > Cash registers > New cash register)
3) Add some items that can be purchased (Home > Point of sale > Purchase items > New debit type)
   . Enter a 'Debit type code', 'Default amount', 'Description', tick 'Can be manually invoiced?' and 'Can be sold?', and select 'All libraries' for the 'Libraries limitation'
   . Repeat so that you have two or three items
4) Add a sales transaction
   . Home > Point of sale
   . Click on 'Add' next to an item in the 'Items for purchase' area
   . Add another item
   . Under the 'Collect payment' area  enter the amount collected from the patron
   . Click 'Confirm'
   . Keep a record of the transactions for step 7
   . Repeat and add another sales transaction
5) Go to the Branch details screen - this lists the cash registers for the branch and allows you to 'Record cashup' either for an individual register all all registers
6) Click on 'Record cashup' button for the cash register setup in step 2
7) This lists all the transactions - check that transactions match with the transactions you entered
8) Check that the summary figires match
9) From the cash registers screen check that you can archive and restore a cash register
10) Form the cash registers screen check that you can change the details for a cash register
11) Sign-off bug!

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 98020 [details]
Bugs 24492 - Screenshot of POS screen

Just a couple of minor points on the screen layout:

- In the items for purchase area the search box and labels are not aligned very well. This applies to the show entries label as well. (Tested on Google Chrome and Firefox).

- It may be better to have the 'Confirm' button and 'Cancel' link under the collect payment section to better fit a normal workflow: add items, enter payment details then press confirm.

Created attachment 100153 [details] [review]
Bug 24492: Add branch details page

This patch adds a new 'branch details' page to the POS system which
displays a summary of the cash register transactions for a branch
since each register was last cashed up. It also allows for cashing
up individual registers or cashing up all registers at a given branch
in one transaction.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: David Nind <david@davidnind.com>

Created attachment 100154 [details] [review]
Bug 24492: Update GPL license

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Created attachment 100189 [details] [review]
Bug 24492: Add branch details page

This patch adds a new 'branch details' page to the POS system which
displays a summary of the cash register transactions for a branch
since each register was last cashed up. It also allows for cashing
up individual registers or cashing up all registers at a given branch
in one transaction.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Created attachment 100190 [details] [review]
Bug 24492: Update GPL license

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Just a last rebase before pushing :).. Thanks for testing guys

Nice work everyone!

Pushed to master for 20.05

Created attachment 100196 [details] [review]
Bug 24492: (RM follow-up) Redirect to correct page after cashup

Cashup of a single register was resulting in a redirect to the register
details page. It should return to the branch details page instead.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

enhancement not backported to 19.11.x

Created attachment 102433 [details] [review]
Bug 24492: (RM follow-up) Varaible name corretion

Bug 24492 was not correctly rebased after bug 23355 and did not account
for a variable name change in the 'add_cashup' action. This patch deals
with that.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Nice work everyone!

Pushed to master for 20.05

*** Bug 24792 has been marked as a duplicate of this bug. ***