Description
Martin Renvoize (ashimema)
2019-11-27 16:26:46 UTC
Perhaps we could convert to using markdown formatted notes in updatedatabase? I think that could work well on both and line and parsed for the browser view. Created attachment 98536 [details] [review] Bug 24131: Move the print statement to a new subroutine Created attachment 98537 [details] [review] Bug 24131: Handle several descriptions What did you have in mind exactly? It will be hard to make things flexible as we are using a log file to write the output of the script. I have the feeling that if we want flexibility we will need to move stuff to a module. Maybe also use a DB table to keep track of the upgrades and errors? Created attachment 99315 [details] [review] Bug 24131: Move the print statement to a new subroutine Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 99316 [details] [review] Bug 24131: Handle several descriptions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 99317 [details] [review] Bug 24131: (follow-up) Fix and rebase Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Well.. this patch doesn't go as far as I was initially thinking and goes in a bit of a different direction.. but I like the factoring out of the version statement and believe it can be used as the basis for more work. As such, I'm signing if off as is. I toyed with adding colour output for the terminal, but that is a bigger piece that would require code in the controller to either strip out the color sequences or upgrade them to css classes or something. I have however added a new bug which adds timestamps to the output based atop this to show where we could go with it. Signing off One issue I did spot, however, was that the tab spacing is stripped when going via the web installer. It would be good to fix that here. Patch no longer applies: Bug 24131 - Improved formatting for output of updatedatabase 99315 - Bug 24131: Move the print statement to a new subroutine 99316 - Bug 24131: Handle several descriptions 99317 - Bug 24131: (follow-up) Fix and rebase Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 24131: Move the print statement to a new subroutine Applying: Bug 24131: Handle several descriptions Applying: Bug 24131: (follow-up) Fix and rebase error: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). error: could not build fake ancestor Patch failed at 0001 Bug 24131: (follow-up) Fix and rebase Created attachment 99521 [details] [review] Bug 24131: Move the print statement to a new subroutine Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 99522 [details] [review] Bug 24131: Handle several descriptions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 99523 [details] [review] Bug 24131: (follow-up) Fix and rebase Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 99524 [details] [review] Bug 24131: (follow-up) Another rebase Created attachment 100161 [details] [review] Bug 24131: Move the print statement to a new subroutine Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 100162 [details] [review] Bug 24131: Handle several descriptions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 100163 [details] [review] Bug 24131: (follow-up) Fix and rebase Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 100164 [details] [review] Bug 24131: (follow-up) Another rebase Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested loading 19.11 database, then running updatedatabase.pl on cli, or using webinstaller. Looks better on cli :) Created attachment 100464 [details] [review] Bug 24131: Move the print statement to a new subroutine Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 100465 [details] [review] Bug 24131: Handle several descriptions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 100466 [details] [review] Bug 24131: (follow-up) Fix and rebase Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 100467 [details] [review] Bug 24131: (follow-up) Another rebase Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Created attachment 100468 [details] [review] Bug 24131: (QA follow-up) Formatting in web client Applying: Bug 24131: (follow-up) Another rebase error: sha1 information is lacking or useless (installer/data/mysql/updatedatabase.pl). error: could not build fake ancestor Hmm.. not sure why we're getting sha1 issue here.. as an alternative I've pushed a branch to my gitlab: https://gitlab.com/mrenvoize/Koha/-/tree/bug_24131 Created attachment 100530 [details] [review] Bug 24131: Remove bullet points for secondary descriptions Created attachment 100531 [details] [review] Bug 24131: Move the print statement to a new subroutine Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 100532 [details] [review] Bug 24131: Handle several descriptions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 100533 [details] [review] Bug 24131: (follow-up) Fix and rebase Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 100534 [details] [review] Bug 24131: (follow-up) Another rebase Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 100535 [details] [review] Bug 24131: (QA follow-up) Formatting in web client Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 100536 [details] [review] Bug 24131: Remove bullet points for secondary descriptions Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 100538 [details] [review] Bug 24131: Always display bug numbers on 5 characters To correctly align bug numbers < 10000 Created attachment 101155 [details] [review] Bug 24131: Move the print statement to a new subroutine Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 101159 [details] [review] Bug 24131: Handle several descriptions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 101160 [details] [review] Bug 24131: (follow-up) Fix and rebase Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 101162 [details] [review] Bug 24131: (follow-up) Another rebase Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 101164 [details] [review] Bug 24131: (QA follow-up) Formatting in web client Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 101166 [details] [review] Bug 24131: Remove bullet points for secondary descriptions Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 101168 [details] [review] Bug 24131: Always display bug numbers on 5 characters To correctly align bug numbers < 10000 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 101187 [details]
Bug numbers don't align
Just a note that 4 character bug numbers won't align due to browsers collapsing whitespace. Not a blocker IMO. Could be solved with CSS or just non-breaking spaces. Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x Created attachment 103001 [details] [review] Bug 24131: Prevent the first description to be displayed twice If there are several lines to display, the first one was displayed twice: Upgrade to 19.12.00.071 done [13:10:22]: Bug 22887 - Add unique constraint to authorised_values - Add unique constraint to authorised_values - WARNING - Cannot create unique constraint on authorised_value(category, authorised_value) - The following entries are duplicated: COUNTRY:aaa (2) Nice work everyone! Pushed to master for 20.05 |