Updatedatabase reports a line for each update, but there's no time added so it's hard to track down which update was responsible for a very long-running upgrade if you're not actually watching the upgrade.
Created attachment 99318 [details] [review] Bug 24696: Add completion times to updatedatabase This patch adds completion times to the print statements in updateadatabase.pl. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 99525 [details] [review] Bug 24696: Add completion times to updatedatabase This patch adds completion times to the print statements in updateadatabase.pl. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Test plan. Run updatedatabase (via either command line or staff client) and note that since the 19.12.00 update we now include timestamps in the output. QA note, I'm tempted to backdate this timestamp handling to prior versions on the release of 20.05 as part of this cycle release process.
Created attachment 99529 [details] [review] Bug 24696: Use strftime Seems easier to me.
(In reply to Jonathan Druart from comment #4) > Created attachment 99529 [details] [review] [review] > Bug 24696: Use strftime > > Seems easier to me. Good call
Created attachment 99736 [details] [review] Bug 24696: Add completion times to updatedatabase This patch adds completion times to the print statements in updateadatabase.pl. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested on top of Bug 24131 Work Ok, no errors.
Created attachment 99737 [details] [review] Bug 24696: Use strftime Seems easier to me. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Here is how it looks: https://snipboard.io/QG3c8A.jpg
Created attachment 100540 [details] [review] Bug 24696: Add completion times to updatedatabase This patch adds completion times to the print statements in updateadatabase.pl. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested on top of Bug 24131 Work Ok, no errors.
Created attachment 100541 [details] [review] Bug 24696: Use strftime Seems easier to me. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 101206 [details] [review] Bug 24696: Add completion times to updatedatabase This patch adds completion times to the print statements in updateadatabase.pl. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested on top of Bug 24131 Work Ok, no errors. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 101207 [details] [review] Bug 24696: Use strftime Seems easier to me. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Nice work everyone! Pushed to master for 20.05
enhancement not backported to 19.11.x