Summary: | Add Koha::Biblio->suggestions | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | 1joynelson, martin.renvoize, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
Bug Depends on: | |||
Bug Blocks: | 23990, 20212, 24419, 24430 | ||
Attachments: |
Bug 24418: Unit tests
Bug 24418: Add Koha::Biblio->suggestions Bug 24418: Add koha_object(s)_class methods to Suggestion Bug 24418: Unit tests Bug 24418: Add Koha::Biblio->suggestions Bug 24418: Add koha_object(s)_class methods to Suggestion Bug 24418: Unit tests Bug 24418: Add Koha::Biblio->suggestions Bug 24418: Add koha_object(s)_class methods to Suggestion Bug 24418: Unit tests |
Description
Tomás Cohen Arazi
2020-01-14 13:04:14 UTC
Created attachment 97349 [details] [review] Bug 24418: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 97350 [details] [review] Bug 24418: Add Koha::Biblio->suggestions This patch adds the mentioned accessor. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 97351 [details] [review] Bug 24418: Add koha_object(s)_class methods to Suggestion Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 97353 [details] [review] Bug 24418: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 97365 [details] [review] Bug 24418: Add Koha::Biblio->suggestions This patch adds the mentioned accessor. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 97366 [details] [review] Bug 24418: Add koha_object(s)_class methods to Suggestion Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 97367 [details] [review] Bug 24418: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 97382 [details] [review] Bug 24418: Add Koha::Biblio->suggestions This patch adds the mentioned accessor. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 97383 [details] [review] Bug 24418: Add koha_object(s)_class methods to Suggestion Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 97384 [details] [review] Bug 24418: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Simple clear code and passes qa scripts.. Passing QA Nice work everyone! Pushed to master for 20.05 Enhancement not backported to 19.11.x |