Bug 23991 - Move SearchSuggestion to Koha::Suggestions
> git grep "GetSuggestion[^a-zA-Z]" C4/Acquisition.pm:use C4::Suggestions qw( GetSuggestion GetSuggestionFromBiblionumber ModSuggestion ); C4/Suggestions.pm:\%sth = &GetSuggestion($suggestionid) C4/Suggestions.pm:sub GetSuggestion { C4/Suggestions.pm: my $full_suggestion = GetSuggestion( $suggestion->{suggestionid} ); acqui/basket.pl:use C4::Suggestions qw( GetSuggestion GetSuggestionInfoFromBiblionumber GetSuggestionInfo ); acqui/neworderempty.pl:use C4::Suggestions qw( GetSuggestion GetSuggestionInfo ); acqui/neworderempty.pl: $data = GetSuggestion($suggestionid); acqui/orderreceive.pl:use C4::Suggestions qw( GetSuggestion GetSuggestionInfoFromBiblionumber GetSuggestionInfo ); acqui/parcel.pl:use C4::Suggestions qw( GetSuggestion GetSuggestionInfoFromBiblionumber GetSuggestionInfo ); misc/release_notes/release_notes_3_20_0.txt: 13201 normal GetSuggestion takes suggestionid suggestion/suggestion.pl: $suggestion_ref = &GetSuggestion( $$suggestion_ref{'suggestionid'} ); suggestion/suggestion.pl: $suggestion_ref = &GetSuggestion( $$suggestion_ref{'suggestionid'} ); t/db_dependent/Suggestions.t: qw( GetSuggestion ModSuggestion GetSuggestionInfo GetSuggestionFromBiblionumber GetSuggestionInfoFromBiblionumber GetSuggestionByStatus ConnectSuggestionAndBiblio DelSuggestion MarcRecordFromNewSuggestion GetUnprocessedSuggestions DelSuggestionsOlderThan ) t/db_dependent/Suggestions.t:is( GetSuggestion(), undef, 'GetSuggestion without the suggestion id returns undef' ); t/db_dependent/Suggestions.t:my $suggestion = GetSuggestion($my_suggestionid); t/db_dependent/Suggestions.t:$suggestion = GetSuggestion($my_suggestionid); t/db_dependent/Suggestions.t:$suggestion = GetSuggestion($my_suggestionid); t/db_dependent/Suggestions.t:$suggestion = GetSuggestion($my_suggestionid); t/db_dependent/Suggestions.t:$suggestion = GetSuggestion($my_suggestionid_test_budgetid); t/db_dependent/Suggestions.t:$suggestion = GetSuggestion($my_suggestionid_test_budgetid); t/db_dependent/Suggestions.t: my $suggestion = GetSuggestion($my_suggestionid); t/db_dependent/Suggestions.t: $suggestion = GetSuggestion($my_suggestionid); t/db_dependent/Suggestions.t: $suggestion = GetSuggestion($my_suggestionid); t/db_dependent/Suggestions.t: $suggestion = GetSuggestion($my_suggestionid);
Created attachment 180826 [details] [review] Bug 23990: Remove GetSuggestion from C4/Suggestions.pm This set of patches removes the major part of C4/Suggestions. They have been split for sake of QA's readability but should be squashed. Things to test: Create suggestion Update status of suggestion Create, see and receive an order containing a suggestion Create a suggestion on an already existing record (it will need validation) test cronjobs purge_suggestion and notice_unprocessed_suggestions
Created attachment 180827 [details] [review] Bug 23990: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Created attachment 180828 [details] [review] Bug 23990: Remove GetSuggestionInfoFromBiblionumber from C4/Suggestions.pm
Created attachment 180829 [details] [review] Bug 23990: Remove GetSuggestionInfo from C4/Suggestions.pm
Created attachment 180830 [details] [review] Bug 23990: Remove GetSuggestionByStatus from C4/Suggestions.pm Note: not used in koha
Created attachment 180831 [details] [review] Bug 23990: Remove op connectDuplicate from acqui/newordersuggestions.pl 15:27:09> git grep connectDuplicate acqui/newordersuggestion.pl: * connectDuplicate : acqui/newordersuggestion.pl:if ( $op eq 'connectDuplicate' ) { connectDuplicate is never called from any template code is hence removed
Created attachment 180832 [details] [review] Bug 23990: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm
Created attachment 180833 [details] [review] Bug 23990: Remove DelSuggestionsOlderThan from C4/Suggestions.pm
Created attachment 180834 [details] [review] Bug 23990: Add option -exact_days to filter_by_last_update
Created attachment 180835 [details] [review] Bug 23990: Remove GetUnprocessedSuggestions from C4/Suggestions.pm
Created attachment 180836 [details] [review] Bug 23990: Remove DelSuggestions from C4/Suggestions.pm
Created attachment 180837 [details] [review] Bug 23990: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm