Bug 23990 - Move C4::Suggestions code to the Koha namespace
Summary: Move C4::Suggestions code to the Koha namespace
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Baptiste Wojtkowski (bwoj)
QA Contact: Testopia
URL:
Keywords:
Depends on: 39732 23991 24418 33236
Blocks: 15449
  Show dependency treegraph
 
Reported: 2019-11-07 16:37 UTC by Jonathan Druart
Modified: 2025-04-24 09:27 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 23990: Remove GetSuggestion from C4/Suggestions.pm (13.26 KB, patch)
2025-04-11 10:51 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 23990: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm (4.32 KB, patch)
2025-04-11 10:51 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 23990: Remove GetSuggestionInfoFromBiblionumber from C4/Suggestions.pm (8.73 KB, patch)
2025-04-11 10:51 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 23990: Remove GetSuggestionInfo from C4/Suggestions.pm (6.63 KB, patch)
2025-04-11 10:51 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 23990: Remove GetSuggestionByStatus from C4/Suggestions.pm (6.97 KB, patch)
2025-04-11 10:51 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 23990: Remove op connectDuplicate from acqui/newordersuggestions.pl (1.35 KB, patch)
2025-04-11 10:51 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 23990: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm (3.66 KB, patch)
2025-04-11 10:51 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 23990: Remove DelSuggestionsOlderThan from C4/Suggestions.pm (4.83 KB, patch)
2025-04-11 10:51 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 23990: Add option -exact_days to filter_by_last_update (2.08 KB, patch)
2025-04-11 10:51 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 23990: Remove GetUnprocessedSuggestions from C4/Suggestions.pm (6.08 KB, patch)
2025-04-11 10:51 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 23990: Remove DelSuggestions from C4/Suggestions.pm (5.83 KB, patch)
2025-04-11 10:51 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 23990: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm (11.12 KB, patch)
2025-04-11 10:51 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2019-11-07 16:37:52 UTC

    
Comment 1 Jonathan Druart 2019-11-07 16:39:53 UTC
Bug 23991 - Move SearchSuggestion to Koha::Suggestions
Comment 2 Baptiste Wojtkowski (bwoj) 2025-04-07 12:19:38 UTC Comment hidden (obsolete)
Comment 3 Baptiste Wojtkowski (bwoj) 2025-04-11 10:51:10 UTC
Created attachment 180826 [details] [review]
Bug 23990: Remove GetSuggestion from C4/Suggestions.pm

This set of patches removes the major part of C4/Suggestions. They have
been split for sake of QA's readability but should be squashed.

Things to test:
Create suggestion
Update status of suggestion
Create, see and receive an order containing a suggestion
Create a suggestion on an already existing record (it will need
        validation)
test cronjobs purge_suggestion and notice_unprocessed_suggestions
Comment 4 Baptiste Wojtkowski (bwoj) 2025-04-11 10:51:12 UTC
Created attachment 180827 [details] [review]
Bug 23990: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Comment 5 Baptiste Wojtkowski (bwoj) 2025-04-11 10:51:15 UTC
Created attachment 180828 [details] [review]
Bug 23990: Remove GetSuggestionInfoFromBiblionumber from C4/Suggestions.pm
Comment 6 Baptiste Wojtkowski (bwoj) 2025-04-11 10:51:17 UTC
Created attachment 180829 [details] [review]
Bug 23990: Remove GetSuggestionInfo from C4/Suggestions.pm
Comment 7 Baptiste Wojtkowski (bwoj) 2025-04-11 10:51:20 UTC
Created attachment 180830 [details] [review]
Bug 23990: Remove GetSuggestionByStatus from C4/Suggestions.pm

Note: not used in koha
Comment 8 Baptiste Wojtkowski (bwoj) 2025-04-11 10:51:23 UTC
Created attachment 180831 [details] [review]
Bug 23990: Remove op connectDuplicate from acqui/newordersuggestions.pl

15:27:09> git grep connectDuplicate
acqui/newordersuggestion.pl:    * connectDuplicate :
acqui/newordersuggestion.pl:if ( $op eq 'connectDuplicate' ) {

connectDuplicate is never called from any template code is hence removed
Comment 9 Baptiste Wojtkowski (bwoj) 2025-04-11 10:51:26 UTC
Created attachment 180832 [details] [review]
Bug 23990: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm
Comment 10 Baptiste Wojtkowski (bwoj) 2025-04-11 10:51:30 UTC
Created attachment 180833 [details] [review]
Bug 23990: Remove DelSuggestionsOlderThan from C4/Suggestions.pm
Comment 11 Baptiste Wojtkowski (bwoj) 2025-04-11 10:51:33 UTC
Created attachment 180834 [details] [review]
Bug 23990: Add option -exact_days to filter_by_last_update
Comment 12 Baptiste Wojtkowski (bwoj) 2025-04-11 10:51:36 UTC
Created attachment 180835 [details] [review]
Bug 23990: Remove GetUnprocessedSuggestions from C4/Suggestions.pm
Comment 13 Baptiste Wojtkowski (bwoj) 2025-04-11 10:51:40 UTC
Created attachment 180836 [details] [review]
Bug 23990: Remove DelSuggestions from C4/Suggestions.pm
Comment 14 Baptiste Wojtkowski (bwoj) 2025-04-11 10:51:42 UTC
Created attachment 180837 [details] [review]
Bug 23990: Remove MarcRecordFromNewSuggestion from C4/Suggestions.pm