| Summary: | Put OPAC cart download options into dropdown menu | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, david, dcook, jonathan.druart, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9073 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement adds the OPAC cart download format options into the dropdown menu, rather than opening in a separate pop up window. (This also matches the behaviour in the staff interface.)
|
Version(s) released in: |
20.11.00, 20.05.02
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 5087, 26005 | ||
| Attachments: |
Bug 25402: Put OPAC cart download options into dropdown menu
Bug 25402: Put OPAC cart download options into dropdown menu Bug 25402: (QA follow-up) Remove unused downloadBasket function Bug 25402: Put OPAC cart download options into dropdown menu Bug 25402: (QA follow-up) Remove unused downloadBasket function |
||
|
Description
Owen Leonard
2020-05-06 20:26:22 UTC
Created attachment 104717 [details] [review] Bug 25402: Put OPAC cart download options into dropdown menu This patch modifies the process of downloading a cart so that it doesn't involve a separate popup window. To test, apply the patch and add some titles to the cart in the OPAC. - Open the cart - The "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC Created attachment 105046 [details] [review] Bug 25402: Put OPAC cart download options into dropdown menu This patch modifies the process of downloading a cart so that it doesn't involve a separate popup window. To test, apply the patch and add some titles to the cart in the OPAC. - Open the cart - The "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> This is great, I didn't like having a pop-up inside of a pop-up. Thanks Owen. Should/could we not remove downloadBasket with this patch? Was wondering because I expected the pull down code to be removed elsewhere in the patch set. Created attachment 106001 [details] [review] Bug 25402: (QA follow-up) Remove unused downloadBasket function This patch removes the now-unused downloadBasket function from basket.js. The patch should have no effect on the functionality of the download process. Created attachment 106113 [details] [review] Bug 25402: Put OPAC cart download options into dropdown menu This patch modifies the process of downloading a cart so that it doesn't involve a separate popup window. To test, apply the patch and add some titles to the cart in the OPAC. - Open the cart - The "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 106114 [details] [review] Bug 25402: (QA follow-up) Remove unused downloadBasket function This patch removes the now-unused downloadBasket function from basket.js. The patch should have no effect on the functionality of the download process. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> It would be good to remove downloadBasket from koha-tmpl/intranet-tmpl/prog/js/basket.js as well, on its own bug report ofc. Pushed to master for 20.11, thanks to everybody involved! choosing to backport enhancement backported to 20.05.x for 20.05.02 enhancement, not backporting to 19.11.x |