Bug 26005 - OPAC cart display fails with error
Summary: OPAC cart display fails with error
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low critical (vote)
Assignee: Owen Leonard
QA Contact: Tomás Cohen Arazi
URL:
Keywords:
Depends on: 25402
Blocks: 26008
  Show dependency treegraph
 
Reported: 2020-07-17 13:55 UTC by Owen Leonard
Modified: 2020-08-03 22:44 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Who signed the patch off:
Text to go in the release notes:
This fixes a problem with the OPAC cart - it should now work correctly when opened, instead of generating an error message.
Version(s) released in:
20.11.00, 20.05.03


Attachments
Bug 26005: OPAC cart display fails with error (1.11 KB, patch)
2020-07-17 14:00 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 26005: OPAC cart display fails with error (1.25 KB, patch)
2020-07-20 11:35 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 26005: OPAC cart display fails with error (1.31 KB, patch)
2020-07-20 12:42 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2020-07-17 13:55:38 UTC
Bug 25402 was supposed to have depended on Bug 5087 but somehow that got missed during QA. 

The result is that the OPAC cart is completely broken, giving this error when the cart window is opened:

DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'opac_option' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 144
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77
Comment 1 Owen Leonard 2020-07-17 14:00:12 UTC
Created attachment 107012 [details] [review]
Bug 26005: OPAC cart display fails with error

This patch removes the "opac_option" parameter from opac-basket.pl. It
was included in Bug 25402 because the bug was dependent on 5087.

To test, apply the patch and add some items to the Cart in the OPAC.
Click the Cart button to show the cart. The pop-up window should load
correctly without errors.
Comment 2 Frédéric Demians 2020-07-20 11:35:45 UTC
Created attachment 107086 [details] [review]
Bug 26005: OPAC cart display fails with error

This patch removes the "opac_option" parameter from opac-basket.pl. It
was included in Bug 25402 because the bug was dependent on 5087.

To test, apply the patch and add some items to the Cart in the OPAC.
Click the Cart button to show the cart. The pop-up window should load
correctly without errors.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Comment 3 Tomás Cohen Arazi 2020-07-20 12:42:43 UTC
Created attachment 107088 [details] [review]
Bug 26005: OPAC cart display fails with error

This patch removes the "opac_option" parameter from opac-basket.pl. It
was included in Bug 25402 because the bug was dependent on 5087.

To test, apply the patch and add some items to the Cart in the OPAC.
Click the Cart button to show the cart. The pop-up window should load
correctly without errors.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi 2020-07-20 12:46:20 UTC
Out of the scope of this bug: why did we loose control on which profiles can be used in the OPAC? I will file a bug for that. The current implementation doesn't allow to limit which profiles to offer the end-user.
Comment 5 Jonathan Druart 2020-07-20 15:49:34 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 6 Katrin Fischer 2020-07-20 20:27:11 UTC
(In reply to Tomás Cohen Arazi from comment #4)
> Out of the scope of this bug: why did we loose control on which profiles can
> be used in the OPAC? I will file a bug for that. The current implementation
> doesn't allow to limit which profiles to offer the end-user.

Hi, what profiles do you mean?
Comment 7 Tomás Cohen Arazi 2020-07-20 20:34:22 UTC
(In reply to Katrin Fischer from comment #6)
> (In reply to Tomás Cohen Arazi from comment #4)
> > Out of the scope of this bug: why did we loose control on which profiles can
> > be used in the OPAC? I will file a bug for that. The current implementation
> > doesn't allow to limit which profiles to offer the end-user.
> 
> Hi, what profiles do you mean?

I didn't notice bug 5087, so I thougt that was already part of Koha.
Comment 8 Lucas Gass 2020-07-25 18:07:36 UTC
backported to 20.05.x for 20.05.03
Comment 9 Aleisha Amohia 2020-08-03 22:44:02 UTC
missing dependencies, not backported to 19.11.x