| Summary: | Perl undef warning on the "About Koha" page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Slava Shishkin <slavashishkin> |
| Component: | About | Assignee: | Slava Shishkin <slavashishkin> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | aleisha, nugged, stalkernoid, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.07, 19.05.12
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 25790 | ||
| Attachments: |
Bug 25506: Fix for "Use of uninitialized value" in about.pl
Bug 25506: Fix for "Use of uninitialized value" in about.pl Bug 25506: Fix for "Use of uninitialized value" in about.pl |
||
|
Description
Slava Shishkin
2020-05-14 14:51:05 UTC
Created attachment 104892 [details] [review] Bug 25506: Fix for "Use of uninitialized value" in about.pl Perl warning on the "About Koha" page: Use of uninitialized value in string eq at /home/vagrant/kohaclone/about.pl line 220. Fixed by adding additional precheck for C4::Context->config('zebra_auth_index_mode') being Perl's "true". To test: 1) Ensure you don't have "<zebra_auth_index_mode>... </zebra_auth_index_mode>" in your koha-conf.xml so you will have "C4::Context->config" returning "undef" 2) Go to the "About Koha" page. 3) Observe the warning in the log file. 4) Apply patch. 5) Repeat step 2. 6) Check that previous warning was suppressed. Created attachment 104980 [details] [review] Bug 25506: Fix for "Use of uninitialized value" in about.pl Perl warning on the "About Koha" page: Use of uninitialized value in string eq at /home/vagrant/kohaclone/about.pl line 220. Fixed by adding additional precheck for C4::Context->config('zebra_auth_index_mode') being Perl's "true". To test: 1) Ensure you don't have "<zebra_auth_index_mode>... </zebra_auth_index_mode>" in your koha-conf.xml so you will have "C4::Context->config" returning "undef" 2) Go to the "About Koha" page. 3) Observe the warning in the log file. 4) Apply patch. 5) Repeat step 2. 6) Check that previous warning was suppressed. Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> Created attachment 105192 [details] [review] Bug 25506: Fix for "Use of uninitialized value" in about.pl Perl warning on the "About Koha" page: Use of uninitialized value in string eq at /home/vagrant/kohaclone/about.pl line 220. Fixed by adding additional precheck for C4::Context->config('zebra_auth_index_mode') being Perl's "true". To test: 1) Ensure you don't have "<zebra_auth_index_mode>... </zebra_auth_index_mode>" in your koha-conf.xml so you will have "C4::Context->config" returning "undef" 2) Go to the "About Koha" page. 3) Observe the warning in the log file. 4) Apply patch. 5) Repeat step 2. 6) Check that previous warning was suppressed. Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 backported to 19.11.x for 19.11.07 Backported to 19.05.x branch for 19.05.12 |