Summary: | overdue_notices.pl dies if no overdue rules are defined | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Architecture, internals, and plumbing | Assignee: | Bugs List <koha-bugs> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 |
||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 17532 | ||
Bug Blocks: |
Description
David Cook
2020-06-01 05:31:30 UTC
Yes, even with bug 25634 fixed I think we should replace the die with a warn+exit 0 Is that a regression? We certainly have libraries without rules and multiple instances on servers... Having no rules should not be seen as a problem or error, it's just configuration. The behaviour of the script has not been modified, but the consequence on koha-foreach comes from a change in koha-shell (bug 17532) That explains why we haven't run into this yet on production systems. (In reply to Jonathan Druart from comment #1) > Yes, even with bug 25634 fixed I think we should replace the die with a > warn+exit 0 That's my thinking too. Will this be fixed by bug 17532 or do we need to adjust the overdues script as well? (In reply to Katrin Fischer from comment #6) > Will this be fixed by bug 17532 or do we need to adjust the overdues script > as well? Bug 17532 actually makes this a problem as noted in Bug 25634. Bug 25634 resolves the main problem that Bug 17532 introduced, but the overdues script should be adjusted anyway. I think that this might arguably be a duplicate of bug 38307 The original problem was resolved by bug 25634 and bug 38307 controls the verbosity of the warning so I think that's all good. I don't think I've had any issues in prod for several years so happy to close this one *** This bug has been marked as a duplicate of bug 38307 *** |