overdue_notices.pl dies if no overdue rules are defined, but there are many cases where you might not want any overdue rules to be defined. (If you're running overdue_notices.pl within koha-foreach, koha-foreach will now die on the first instance it encounters that has no overdue rules defined.)
Yes, even with bug 25634 fixed I think we should replace the die with a warn+exit 0
Is that a regression? We certainly have libraries without rules and multiple instances on servers... Having no rules should not be seen as a problem or error, it's just configuration.
The behaviour of the script has not been modified, but the consequence on koha-foreach comes from a change in koha-shell (bug 17532)
That explains why we haven't run into this yet on production systems.
(In reply to Jonathan Druart from comment #1) > Yes, even with bug 25634 fixed I think we should replace the die with a > warn+exit 0 That's my thinking too.
Will this be fixed by bug 17532 or do we need to adjust the overdues script as well?
(In reply to Katrin Fischer from comment #6) > Will this be fixed by bug 17532 or do we need to adjust the overdues script > as well? Bug 17532 actually makes this a problem as noted in Bug 25634. Bug 25634 resolves the main problem that Bug 17532 introduced, but the overdues script should be adjusted anyway.
I think that this might arguably be a duplicate of bug 38307 The original problem was resolved by bug 25634 and bug 38307 controls the verbosity of the warning so I think that's all good. I don't think I've had any issues in prod for several years so happy to close this one *** This bug has been marked as a duplicate of bug 38307 ***