Created attachment 173742 [details] [review] Bug 38307: Make overdue_notices.pl die quietly if no branches have overdue rules If no patron categories require overdue notices, then there will be no overdue rules/status triggers. This isn't necessarily a bad thing and shouldn't be noisy. To test: 1. Go to Administration -> Patron categories 2. Set all your category types to have overdue notice required: No 3. Go to Tools -> Overdue notices/status triggers 4. Notice you're unable to set any overdue rules 5. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error about no overdue rules is printed 6. Apply the patch and restart services 7. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error is not printed 8. Run the cronjob misc/cronjobs/overdue_notices.pl --verbose and notice the error is printed Sponsored-by: Catalyst IT
*** Bug 25635 has been marked as a duplicate of this bug. ***
Not testable in a sandbox.
Created attachment 176383 [details] [review] Bug 38307: Make overdue_notices.pl die quietly if no branches have overdue rules If no patron categories require overdue notices, then there will be no overdue rules/status triggers. This isn't necessarily a bad thing and shouldn't be noisy. To test: 1. Go to Administration -> Patron categories 2. Set all your category types to have overdue notice required: No 3. Go to Tools -> Overdue notices/status triggers 4. Notice you're unable to set any overdue rules 5. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error about no overdue rules is printed 6. Apply the patch and restart services 7. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error is not printed 8. Run the cronjob misc/cronjobs/overdue_notices.pl --verbose and notice the error is printed Sponsored-by: Catalyst IT Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com>
Created attachment 178476 [details] [review] Bug 38307: Make overdue_notices.pl die quietly if no branches have overdue rules If no patron categories require overdue notices, then there will be no overdue rules/status triggers. This isn't necessarily a bad thing and shouldn't be noisy. To test: 1. Go to Administration -> Patron categories 2. Set all your category types to have overdue notice required: No 3. Go to Tools -> Overdue notices/status triggers 4. Notice you're unable to set any overdue rules 5. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error about no overdue rules is printed 6. Apply the patch and restart services 7. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error is not printed 8. Run the cronjob misc/cronjobs/overdue_notices.pl --verbose and notice the error is printed Sponsored-by: Catalyst IT Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 25.05! Well done everyone, thank you!