Bug 26916

Summary: Show searchable patron attributes in patron search dropdown
Product: Koha Reporter: Andrew Fuerste-Henry <andrewfh>
Component: Staff interfaceAssignee: Nick Clemens <nick>
Status: Needs documenting --- QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: anni.rajala, fridolin.somers, gmcharlt, katrin.fischer, nick
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Bug Depends on: 17374, 34519    
Bug Blocks: 34517, 35303    
Attachments: Bug 26916: Show searchable patron attributes in patron search dropdown
Bug 26916: Adjust unit tests
Bug 26916: Show searchable patron attributes in patron search dropdown
Bug 26916: Adjust unit tests
Bug 26916: Show searchable patron attributes in patron search dropdown
Bug 26916: Adjust unit tests
Bug 26916: Show searchable patron attributes in patron search dropdown
Bug 26916: Adjust unit tests

Description Andrew Fuerste-Henry 2020-11-03 21:38:29 UTC
following bug 17374, fields listed in DefaultPatronSearchFields also appear in the patron search fields dropdown. It would be great to be able to get patron attributes to show in that dropdown, too.
Comment 1 Andrew Fuerste-Henry 2022-02-03 13:48:16 UTC
Flagging an attribute as "searchable" makes it part of the standard patron search, but leaves one without a way to search *only* within that attribute. Adding it to the dropdown would all ow that specificity.
Comment 2 Nick Clemens 2023-08-11 17:41:04 UTC
Created attachment 154385 [details] [review]
Bug 26916: Show searchable patron attributes in patron search dropdown

This patch adds attributes that have been marked searchable to the patron
search dropdowns

To test:
1 - Define some new patron attribute types and make then staff_searchable
2 - Add some values to patrons
3 - Confirm they are searched in 'Standard' search, but there is no other way to search them
4 - Apply patch
5 - Confirm the fields now show in patorn search dropdowns
6 - Search using 'standard' and confirm the searhc works
7 - Search specific attributes and confirm the searhc works
Comment 3 Nick Clemens 2023-08-11 17:41:06 UTC
Created attachment 154386 [details] [review]
Bug 26916: Adjust unit tests
Comment 4 Nick Clemens 2023-08-11 19:32:47 UTC
*** Bug 31868 has been marked as a duplicate of this bug. ***
Comment 5 Nick Clemens 2023-08-17 19:48:34 UTC
Created attachment 154573 [details] [review]
Bug 26916: Show searchable patron attributes in patron search dropdown

This patch adds attributes that have been marked searchable to the patron
search dropdowns

To test:
1 - Define some new patron attribute types and make then staff_searchable
2 - Add some values to patrons
3 - Confirm they are searched in 'Standard' search, but there is no other way to search them
4 - Apply patch
5 - Confirm the fields now show in patorn search dropdowns
6 - Search using 'standard' and confirm the searhc works
7 - Search specific attributes and confirm the searhc works




 Current depends: 17374 34519
Comment 6 Nick Clemens 2023-08-17 19:48:37 UTC
Created attachment 154574 [details] [review]
Bug 26916: Adjust unit tests
Comment 7 Janusz Kaczmarek 2023-08-18 12:27:53 UTC
Created attachment 154653 [details] [review]
Bug 26916: Show searchable patron attributes in patron search dropdown

This patch adds attributes that have been marked searchable to the patron
search dropdowns

To test:
1 - Define some new patron attribute types and make then staff_searchable
2 - Add some values to patrons
3 - Confirm they are searched in 'Standard' search, but there is no other way to search them
4 - Apply patch
5 - Confirm the fields now show in patorn search dropdowns
6 - Search using 'standard' and confirm the searhc works
7 - Search specific attributes and confirm the searhc works

Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Comment 8 Janusz Kaczmarek 2023-08-18 12:27:55 UTC
Created attachment 154654 [details] [review]
Bug 26916: Adjust unit tests

Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Comment 9 Katrin Fischer 2023-10-21 09:10:44 UTC
Blocked by depending patch needing a rebase.
Comment 10 Katrin Fischer 2023-11-05 01:19:10 UTC
Created attachment 158427 [details] [review]
Bug 26916: Show searchable patron attributes in patron search dropdown

This patch adds attributes that have been marked searchable to the patron
search dropdowns

To test:
1 - Define some new patron attribute types and make then staff_searchable
2 - Add some values to patrons
3 - Confirm they are searched in 'Standard' search, but there is no other way to search them
4 - Apply patch
5 - Confirm the fields now show in patorn search dropdowns
6 - Search using 'standard' and confirm the searhc works
7 - Search specific attributes and confirm the searhc works

Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Katrin Fischer 2023-11-05 01:19:13 UTC
Created attachment 158428 [details] [review]
Bug 26916: Adjust unit tests

Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Tomás Cohen Arazi 2023-11-08 20:55:19 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 13 Fridolin Somers 2023-11-11 01:40:22 UTC
Depends on Bug 34519 not in 23.05.x