Description
Andrew Fuerste-Henry
2020-11-03 21:38:29 UTC
Flagging an attribute as "searchable" makes it part of the standard patron search, but leaves one without a way to search *only* within that attribute. Adding it to the dropdown would all ow that specificity. Created attachment 154385 [details] [review] Bug 26916: Show searchable patron attributes in patron search dropdown This patch adds attributes that have been marked searchable to the patron search dropdowns To test: 1 - Define some new patron attribute types and make then staff_searchable 2 - Add some values to patrons 3 - Confirm they are searched in 'Standard' search, but there is no other way to search them 4 - Apply patch 5 - Confirm the fields now show in patorn search dropdowns 6 - Search using 'standard' and confirm the searhc works 7 - Search specific attributes and confirm the searhc works Created attachment 154386 [details] [review] Bug 26916: Adjust unit tests *** Bug 31868 has been marked as a duplicate of this bug. *** Created attachment 154573 [details] [review] Bug 26916: Show searchable patron attributes in patron search dropdown This patch adds attributes that have been marked searchable to the patron search dropdowns To test: 1 - Define some new patron attribute types and make then staff_searchable 2 - Add some values to patrons 3 - Confirm they are searched in 'Standard' search, but there is no other way to search them 4 - Apply patch 5 - Confirm the fields now show in patorn search dropdowns 6 - Search using 'standard' and confirm the searhc works 7 - Search specific attributes and confirm the searhc works Current depends: 17374 34519 Created attachment 154574 [details] [review] Bug 26916: Adjust unit tests Created attachment 154653 [details] [review] Bug 26916: Show searchable patron attributes in patron search dropdown This patch adds attributes that have been marked searchable to the patron search dropdowns To test: 1 - Define some new patron attribute types and make then staff_searchable 2 - Add some values to patrons 3 - Confirm they are searched in 'Standard' search, but there is no other way to search them 4 - Apply patch 5 - Confirm the fields now show in patorn search dropdowns 6 - Search using 'standard' and confirm the searhc works 7 - Search specific attributes and confirm the searhc works Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> Created attachment 154654 [details] [review] Bug 26916: Adjust unit tests Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> Blocked by depending patch needing a rebase. Created attachment 158427 [details] [review] Bug 26916: Show searchable patron attributes in patron search dropdown This patch adds attributes that have been marked searchable to the patron search dropdowns To test: 1 - Define some new patron attribute types and make then staff_searchable 2 - Add some values to patrons 3 - Confirm they are searched in 'Standard' search, but there is no other way to search them 4 - Apply patch 5 - Confirm the fields now show in patorn search dropdowns 6 - Search using 'standard' and confirm the searhc works 7 - Search specific attributes and confirm the searhc works Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 158428 [details] [review] Bug 26916: Adjust unit tests Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Depends on Bug 34519 not in 23.05.x |