The patron search autocomplete is no longer working in master (it was working yesterday, it wasn't after I did a git pull for Koha). To replicate: 1. In the staff interface, start a search for a patron in the header (with check out selected), for example: mary 2. Notice that the autocomplete results are not displayed, and that there is a spinner going round just before the search button. 3. Under web developer tools note that there is a JavaScript error in the console: Uncaught TypeError: search_fields.forEach is not a function buildPatronSearchQuery http://127.0.0.1:8081/intranet-tmpl/prog/js/staff-global_23.0600073.js:615 buildPatronSearchQuery http://127.0.0.1:8081/intranet-tmpl/prog/js/staff-global_23.0600073.js:613 source http://127.0.0.1:8081/intranet-tmpl/prog/js/staff-global_23.0600073.js:453 jQuery 6
Created attachment 158717 [details] [review] Bug 35303: (bug 26916 follow-up) Fix paton autocomplete Fix the following JS error: Uncaught TypeError: search_fields.forEach is not a function
Created attachment 158721 [details] [review] Bug 35303: (bug 26916 follow-up) Fix paton autocomplete Fix the following JS error: Uncaught TypeError: search_fields.forEach is not a function Signed-off-by: David Nind <david@davidnind.com>
Thanks Jonathan!
Created attachment 158742 [details] [review] Bug 35303: (bug 26916 follow-up) Fix paton autocomplete Fix the following JS error: Uncaught TypeError: search_fields.forEach is not a function Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Pushed to master for 23.11. Nice work everyone, thanks!
Depends on Bug 26916 not in 23.05.x