Currently we fetch the searchable attributes in several scripts Moving to a plugin allows us to make a single call from the patron search template
Created attachment 154375 [details] [review] Bug 34519: Add a template plugin for fetch searchable patron attributes This patch moves code form scripts to a template plguin and unifies the calls To test: 1 - Add a searchable patron attribute type 2 - Add values to several patrons and test patron searching from Patrons home Patrons search results Holds request screen Article request screen Patron search sidebar 3 - Apply patch 4 - Confirm results are the same
Created attachment 154376 [details] [review] Bug 34519: Unit tests
Created attachment 154384 [details] [review] Bug 34519: Ensure we always have an array
There are no results when searching with patron extended attribute from: - Holds request screen, and - Article request screen.
Follow-up added to 33428 which should restore the attribute searching on the other screens
Created attachment 154641 [details] [review] Bug 34519: Ensure we always have an array Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Created attachment 154646 [details] [review] Bug 34519: Add a template plugin for fetch searchable patron attributes This patch moves code form scripts to a template plguin and unifies the calls To test: 1 - Add a searchable patron attribute type 2 - Add values to several patrons and test patron searching from Patrons home Patrons search results Holds request screen Article request screen Patron search sidebar 3 - Apply patch 4 - Confirm results are the same Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Created attachment 154647 [details] [review] Bug 34519: Unit tests Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Created attachment 154648 [details] [review] Bug 34519: Ensure we always have an array Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Created attachment 154649 [details] [review] Bug 34519: (follow-up) fix QA tool complaints
Hi Nick, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 34519: Add a template plugin for fetch searchable patron attributes error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc). error: could not build fake ancestor Patch failed at 0001 Bug 34519: Add a template plugin for fetch searchable patron attributes hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-34519-Add-a-template-plugin-for-fetch-searchab-vtceflb2.patch
Created attachment 157649 [details] [review] Bug 34519: Add a template plugin for fetch searchable patron attributes This patch moves code form scripts to a template plguin and unifies the calls To test: 1 - Add a searchable patron attribute type 2 - Add values to several patrons and test patron searching from Patrons home Patrons search results Holds request screen Article request screen Patron search sidebar 3 - Apply patch 4 - Confirm results are the same Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Created attachment 157650 [details] [review] Bug 34519: Unit tests Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Created attachment 157651 [details] [review] Bug 34519: Ensure we always have an array Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Created attachment 157652 [details] [review] Bug 34519: (follow-up) fix QA tool complaints
Created attachment 158423 [details] [review] Bug 34519: Add a template plugin for fetch searchable patron attributes This patch moves code form scripts to a template plguin and unifies the calls To test: 1 - Add a searchable patron attribute type 2 - Add values to several patrons and test patron searching from Patrons home Patrons search results Holds request screen Article request screen Patron search sidebar 3 - Apply patch 4 - Confirm results are the same Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 158424 [details] [review] Bug 34519: Unit tests Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 158425 [details] [review] Bug 34519: Ensure we always have an array Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 158426 [details] [review] Bug 34519: (follow-up) fix QA tool complaints Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Depends on Bug 33428 not in 23.05.x