Summary: | Missing highlighting in Quote of the day | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrewfh, caroline.cyr-la-rose, fridolin.somers, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8797 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.01,20.05.07
|
|
Bug Depends on: | 23013 | ||
Bug Blocks: | 27251 | ||
Attachments: |
Bug 27247: Re-add highlighting to the quote editor
Bug 27247: Re-add highlighting to the quote editor Bug 27247: Re-add highlighting to the quote editor |
Description
Jonathan Druart
2020-12-16 10:29:08 UTC
Caused by commmit 247dca306407ac9568344a0a37aca3bbcffc2468 Bug 23013: Upgrade DataTables in the staff client which removed -tr.even.selected td { - background-color: #D3D3D3; -} Created attachment 114432 [details] [review] Bug 27247: Re-add highlighting to the quote editor Caused by commmit 247dca306407ac9568344a0a37aca3bbcffc2468 Bug 23013: Upgrade DataTables in the staff client which removed -tr.even.selected td { - background-color: #D3D3D3; -} There was no more highlighting when trying to delete an imported quote, as there was before (see screenshot from the manual https://gitlab.com/koha-community/koha-manual/-/blob/master/source/images/tools/qotd/selectfordelete.png) It was, however, possible to delete imported quotes, you just don't see which ones you are deleting. Test plan: 1) Create a CSV with two columns first the name, then the quote (I've attached a CSV that I've done for testing purposes) 2) Go to Tools > Edit quotes for the QOTD feature 3) Click 'Import quotes' 4) Click 'Browse' and choose the CSV created earlier 5) Click on the id of a couple of quotes. Notice those lintes are highlighted Created attachment 114467 [details] [review] Bug 27247: Re-add highlighting to the quote editor Caused by commmit 247dca306407ac9568344a0a37aca3bbcffc2468 Bug 23013: Upgrade DataTables in the staff client which removed -tr.even.selected td { - background-color: #D3D3D3; -} There was no more highlighting when trying to delete an imported quote, as there was before (see screenshot from the manual https://gitlab.com/koha-community/koha-manual/-/blob/master/source/images/tools/qotd/selectfordelete.png) It was, however, possible to delete imported quotes, you just don't see which ones you are deleting. Test plan: 1) Create a CSV with two columns first the name, then the quote (I've attached a CSV that I've done for testing purposes) 2) Go to Tools > Edit quotes for the QOTD feature 3) Click 'Import quotes' 4) Click 'Browse' and choose the CSV created earlier 5) Click on the id of a couple of quotes. Notice those lintes are highlighted Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 114570 [details] [review] Bug 27247: Re-add highlighting to the quote editor Caused by commmit 247dca306407ac9568344a0a37aca3bbcffc2468 Bug 23013: Upgrade DataTables in the staff client which removed -tr.even.selected td { - background-color: #D3D3D3; -} There was no more highlighting when trying to delete an imported quote, as there was before (see screenshot from the manual https://gitlab.com/koha-community/koha-manual/-/blob/master/source/images/tools/qotd/selectfordelete.png) It was, however, possible to delete imported quotes, you just don't see which ones you are deleting. Test plan: 1) Create a CSV with two columns first the name, then the quote (I've attached a CSV that I've done for testing purposes) 2) Go to Tools > Edit quotes for the QOTD feature 3) Click 'Import quotes' 4) Click 'Browse' and choose the CSV created earlier 5) Click on the id of a couple of quotes. Notice those lintes are highlighted Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.01 Pushed to 20.05.x for 20.05.07 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |