I would like to upgrade the DataTables plugin used in the staff client. This process will include:
- A new concatenated, minified version of the
- Removal of the custom "four_button" pagination
configuration in favor of the built-in "full"
- Update style of pagination bars, including
some additions to improve responsive behavior.
Table-specific CSS, including our DataTables CSS,
is now in a separate file, "_tables.scss" which
compiled into staff-global.css.
This is ready for testing, bug Bugzilla rejects the patches because of the size. I've posted the branch here:
I have rebased the branch on GitLab. I have also put a downloadable patch here in case that helps: https://zivotdesign.com/download/bug-23013.patch
On the vendor search: https://snag.gy/dLvxB2.jpg
On the lists page: https://snag.gy/OuBWls.jpg
On the checkouts page:
- before https://snag.gy/VHtmrw.jpg
- after https://snag.gy/N26y1d.jpg
We lost the icons (x, v), the color on hover, and the size is not adjusted (see the last one, "Check in select all"
I forgot to yarn rebuild!
Now I see:
Which is better, but still a misalignment (minor).
In my tests there is some minor misalignment which varies between browsers, usually between one and two pixels. The problem is greater if your page zoom has been increased.
I can work on a follow-up, but I hope this can move forward if that's the only problem which has turned up.
This is looking pretty solid to me.. I can't find any issues (beyond the tiny misalignment problem Jonathan found)
I'm inclined to jump to PQA, as two QA team members have now taken a look.
What I would love to see if the rowGroup plugin (which only currently appears to be used in the checkouts table with minimal effect) bundled within it too now we're using the DT package builder... but that can wait for a followup bug.
Pushed to master for 19.11.00