Summary: | OpacHiddenItems produces a 404 from borrower holds list | ||
---|---|---|---|
Product: | Koha | Reporter: | Martha Fuerst <mfuerst> |
Component: | OPAC | Assignee: | Nick Clemens <nick> |
Status: | In Discussion --- | QA Contact: | Tomás Cohen Arazi <tomascohen> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, magnus, nick, pablo.bianchi, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences |
Description
Martha Fuerst
2021-02-19 15:59:28 UTC
Created attachment 121749 [details] [review] Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Created attachment 121797 [details] [review] Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org> Created attachment 121988 [details] [review] Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org> Created attachment 121989 [details] [review] Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 121990 [details] [review] Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems Test plan: 1 - Apply patch 2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before 3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems: biblionumber: [303] 3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected 4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303 5 - When OpacHiddenRecordRedirect set to 404 you get a 404 6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl' 7 - If you set a message in OpacHiddenRecordMessage it displays on opac-blocked.pl Signed-off-by: marti <mfuerst@hmcpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Should not we stop using syspref for the messages we display on the interface? Should we use "news" instead? See bug 26050. (In reply to Jonathan Druart from comment #6) > Should not we stop using syspref for the messages we display on the > interface? Should we use "news" instead? > > See bug 26050. Actually, I think you are right. It would also be fair, since we had a similar thing just rewritten and this is a quite new patch set. *** This bug has been marked as a duplicate of bug 22286 *** Sorry, I got the duplicity backwards! *** Bug 22286 has been marked as a duplicate of this bug. *** This seems to be strongly related to bug 9966. The staff should be able to let access to bibliographic info even if all items are hidden (similar as with biblios without items). Else, show an appropriate message instead of 404. |