Bug 27734

Summary: OpacHiddenItems produces a 404 from borrower holds list
Product: Koha Reporter: Martha Fuerst <mfuerst>
Component: OPACAssignee: Nick Clemens <nick>
Status: In Discussion --- QA Contact: Tomás Cohen Arazi <tomascohen>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, magnus, nick, pablo.bianchi, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences

Description Martha Fuerst 2021-02-19 15:59:28 UTC
When a borrower clicks on a hold in their holds list they have placed on a title that was subsequently hidden with OpacHiddenItems, it results in a 404 error instead of the "This record is blocked" error page.

It seems like OpacHiddenItems should work the same as individually suppressed records and how they are handled in OpacSuppressionRedirect. This would make more sense from the user's perspective.
Comment 1 Nick Clemens 2021-06-09 19:33:37 UTC
Created attachment 121749 [details] [review]
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences

This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems

Test plan:
1 - Apply patch
2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before
3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems:
    biblionumber: [303]
3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected
4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303
5 - When OpacHiddenRecordRedirect set to 404 you get a 404
6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl'
7 - If you set a message in  OpacHiddenRecordMessage  it displays on opac-blocked.pl
Comment 2 PTFS Europe Sandboxes 2021-06-10 16:14:30 UTC
Created attachment 121797 [details] [review]
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences

This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems

Test plan:
1 - Apply patch
2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before
3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems:
    biblionumber: [303]
3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected
4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303
5 - When OpacHiddenRecordRedirect set to 404 you get a 404
6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl'
7 - If you set a message in  OpacHiddenRecordMessage  it displays on opac-blocked.pl

Signed-off-by: marti <mfuerst@hmcpl.org>
Comment 3 Nick Clemens 2021-06-15 12:03:20 UTC
Created attachment 121988 [details] [review]
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences

This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems

Test plan:
1 - Apply patch
2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before
3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems:
    biblionumber: [303]
3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected
4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303
5 - When OpacHiddenRecordRedirect set to 404 you get a 404
6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl'
7 - If you set a message in  OpacHiddenRecordMessage  it displays on opac-blocked.pl

Signed-off-by: marti <mfuerst@hmcpl.org>
Comment 4 Tomás Cohen Arazi 2021-06-15 12:13:12 UTC
Created attachment 121989 [details] [review]
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences

This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems

Test plan:
1 - Apply patch
2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before
3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems:
    biblionumber: [303]
3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected
4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303
5 - When OpacHiddenRecordRedirect set to 404 you get a 404
6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl'
7 - If you set a message in  OpacHiddenRecordMessage  it displays on opac-blocked.pl

Signed-off-by: marti <mfuerst@hmcpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Tomás Cohen Arazi 2021-06-15 12:28:02 UTC
Created attachment 121990 [details] [review]
Bug 27734: Add OpacHiddenRecordRedirect and OpacHiddenRecordMessage system preferences

This patch adds options analogous to OpacSuppressionRedirect and OpacSuppressionMessage for OpacHiddtenItems

Test plan:
1 - Apply patch
2 - Test OpacSupressionsRedirect and OpacSuppressionMessage prefs to ensure they work as before
3 - Enable OpacHiddenItemsHidesRecord and hide a biblio using OpacHiddenItems:
    biblionumber: [303]
3 - Test OpacHiddenRecordRedirect and OpacHiddenRecordMessage to ensure they work as expected
4 - Hit the link: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=303
5 - When OpacHiddenRecordRedirect set to 404 you get a 404
6 - When OpacHiddenRecordRedirect set to 'an explanatory page' you get 'opac-blocked.pl'
7 - If you set a message in  OpacHiddenRecordMessage  it displays on opac-blocked.pl

Signed-off-by: marti <mfuerst@hmcpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Jonathan Druart 2021-06-21 10:41:32 UTC
Should not we stop using syspref for the messages we display on the interface? Should we use "news" instead?

See bug 26050.
Comment 7 Katrin Fischer 2021-06-21 21:05:59 UTC
(In reply to Jonathan Druart from comment #6)
> Should not we stop using syspref for the messages we display on the
> interface? Should we use "news" instead?
> 
> See bug 26050.

Actually, I think you are right. It would also be fair, since we had a similar thing just rewritten and this is a quite new patch set.
Comment 8 Magnus Enger 2021-06-29 11:18:13 UTC

*** This bug has been marked as a duplicate of bug 22286 ***
Comment 9 Magnus Enger 2021-06-29 11:21:05 UTC
Sorry, I got the duplicity backwards!
Comment 10 Magnus Enger 2021-06-29 11:21:40 UTC
*** Bug 22286 has been marked as a duplicate of this bug. ***
Comment 11 Pablo AB 2022-09-16 18:13:42 UTC
This seems to be strongly related to bug 9966. The staff should be able to let access to bibliographic info even if all items are hidden (similar as with biblios without items). Else, show an appropriate message instead of 404.