| Summary: | Koha::Account::Line->renewable must be named is_renewable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, fridolin.somers, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.05,20.05.11
|
|
| Circulation function: | |||
| Bug Depends on: | 23051, 25508 | ||
| Bug Blocks: | 27995 | ||
| Attachments: |
Bug 28156: Rename Koha::Account::Line->renewal with is_renewal
Bug 28156: Rename Koha::Account::Line->renewal with is_renewal Bug 28156: Rename Koha::Account::Line->renewal with is_renewal |
||
|
Description
Jonathan Druart
2021-04-16 10:09:32 UTC
Created attachment 119703 [details] [review] Bug 28156: Rename Koha::Account::Line->renewal with is_renewal It's a boolean, it must be named is_* Test plan: Confirm that prove t/db_dependent/Koha/Account/Line.t is still returning green Created attachment 119742 [details] [review] Bug 28156: Rename Koha::Account::Line->renewal with is_renewal It's a boolean, it must be named is_* Test plan: Confirm that prove t/db_dependent/Koha/Account/Line.t is still returning green Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 119751 [details] [review] Bug 28156: Rename Koha::Account::Line->renewal with is_renewal It's a boolean, it must be named is_* Test plan: Confirm that prove t/db_dependent/Koha/Account/Line.t is still returning green Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.05 Pushed to 20.05.x for 20.05.11 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |