Bug 25508 - Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off
Summary: Confusing renewal message when paying accruing fine with RenewAccruingItemWhe...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: David Roberts
QA Contact: Testopia
URL:
Keywords:
Depends on: 23051
Blocks:
  Show dependency treegraph
 
Reported: 2020-05-14 21:34 UTC by Andrew Fuerste-Henry
Modified: 2020-11-24 12:59 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2020-05-14 21:34:51 UTC
To recreate:
1 - Make sure FinesMode is on, RenewAccruingItemWhenPaid is off
2 - Checkout an item to a patron and make it overdue (can backdate the checkout)
3 - Make sure the itemtype has fines that will be charged
4 - Charge the fines:
     Set finesMode = production
     perl misc/cronjobs/fines.pl -v
5 - Check the fine appears on the patrons account
6 - Pay off the fine
7 - Receive alert after payment that reads: "The fines on the following items were paid off, renewal results are displayed below:
No title ( ): Not renewed - Unknown error"

Looks like we're not properly hiding that alert when RenewAccruingItemWhenPaid is off? So it's reporting that nothing was renewed?
Comment 1 Katrin Fischer 2020-05-15 06:31:39 UTC
Adding the original bug introducing the feature in depends on - this will also help to get the developers and original testers informed :)