Bug 28247

Summary: Add a MARC preview column to to Authority search results table
Product: Koha Reporter: Timothy Alexis Vass <timothy_alexis.vass>
Component: MARC Authority data supportAssignee: George Veranis <gveranis>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: frank.hansen, gveranis, marjorie.barry-vila, salman.ali
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Adds an new action to the authority search results to show a MARC preview in a modal window on the same page.
Version(s) released in:
Attachments: Bug 28247: Add a MARC preview column to to Authority search results table
Bug 28247: Add a MARC preview column to to Authority search results table
Bug 28247: Add a MARC preview column to to Authority search results table
Bug 28247: (folow up) Add a MARC preview action to Authority search results
Bug 28247: (folow up) Add a MARC preview action to Authority search results
Marc preview

Description Timothy Alexis Vass 2021-04-28 09:00:41 UTC
We added this and want to make it available for others too.
Comment 1 Timothy Alexis Vass 2021-04-28 10:00:16 UTC
Created attachment 120260 [details] [review]
Bug 28247: Add a MARC preview column to to Authority search results table

To test:
1) Do an authority search
2) Notice the MARC preview column
3) Click "Show" for some of the results.
4) Confirm that the correct details are shown.
5) Sign off.
Comment 2 Timothy Alexis Vass 2021-04-28 10:11:19 UTC
Created attachment 120261 [details] [review]
Bug 28247: Add a MARC preview column to to Authority search results table

To test:
1) Do an authority search
2) Notice the MARC preview column
3) Click "Show" for some of the results.
4) Confirm that the correct details are shown.
5) Sign off.

Changed position of the MARC preview column
Comment 3 Salman Ali 2021-06-10 14:43:37 UTC
Created attachment 121795 [details] [review]
Bug 28247: Add a MARC preview column to to Authority search results table

To test:
1) Do an authority search
2) Notice the MARC preview column
3) Click "Show" for some of the results.
4) Confirm that the correct details are shown.
5) Sign off.

Signed-off-by: Salman Ali <salman@outaouais>
Comment 4 Owen Leonard 2021-06-11 11:49:41 UTC
The "Heading type" and "MARC preview" headings are misaligned with regard to the contents of the table, so the "Show" button is under the "Heading type" column header.

To be consistent with other areas of Koha I would ask that the button say "MARC preview." For instance, from the cataloging search results:

<i class="fa fa-eye"></i> MARC preview


Generally if there are other actions grouped in a menu like there are on the authority search results page I would say put any new actions in that menu too. However on this page the results is (for me at least) always quite narrow so there is plenty of room. I'm interested to hear what others think.
Comment 5 Timothy Alexis Vass 2021-06-21 11:58:11 UTC
koha-testing-docker isn't working on my computer and I'm going on holiday, so I won't be able to complete this.
Comment 6 George Veranis 2022-01-07 22:59:55 UTC
Created attachment 129206 [details] [review]
Bug 28247: (folow up) Add a MARC preview action to Authority search results

To test:
1) Do an authority search
2) On Actions button click to see the available actions and click on "MARC
preview" action.
3) A modal window open and confirm that the correct details are shown.
Comment 7 George Veranis 2022-01-07 23:38:30 UTC
*** Bug 15723 has been marked as a duplicate of this bug. ***
Comment 8 Samu Heiskanen 2022-01-09 21:37:29 UTC
Created attachment 129236 [details] [review]
Bug 28247: (folow up) Add a MARC preview action to Authority search results

To test:
1) Do an authority search
2) On Actions button click to see the available actions and click on "MARC
preview" action.
3) A modal window open and confirm that the correct details are shown.

Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi>
Comment 9 Marjorie Barry-Vila 2022-03-01 20:16:22 UTC
(In reply to Samu Heiskanen from comment #8)
> Created attachment 129236 [details] [review] [review]
> Bug 28247: (folow up) Add a MARC preview action to Authority search results
> 
> To test:
> 1) Do an authority search
> 2) On Actions button click to see the available actions and click on "MARC
> preview" action.
> 3) A modal window open and confirm that the correct details are shown.
> 
> Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi>

Hi, 

I just tested in a sandbox (21.12.00.016) (https://staff-bz28247.sandbox.bywatersolutions.com/) and 'Marc preview' appears twice in the Actions menu, is this normal?

Regards

Marjorie
Comment 10 Marjorie Barry-Vila 2022-03-01 20:17:39 UTC
Created attachment 131212 [details]
Marc preview
Comment 11 Katrin Fischer 2022-03-06 14:44:55 UTC
(In reply to Marjorie Barry-Vila from comment #9)
> (In reply to Samu Heiskanen from comment #8)
> Hi, 
> 
> I just tested in a sandbox (21.12.00.016)
> (https://staff-bz28247.sandbox.bywatersolutions.com/) and 'Marc preview'
> appears twice in the Actions menu, is this normal?
> 
> Regards
> 
> Marjorie

Hi Marjorie, please don't hesitate to set "Failed QA" - it sure sounds like we need to check this out!
Comment 12 George Veranis 2022-03-07 22:02:05 UTC
Marjorie you have right, that patch fail now because someone else did another patch that has the same functionality. So that one not is usable anymore.
Comment 13 Katrin Fischer 2022-03-07 22:05:44 UTC
(In reply to George Veranis from comment #12)
> Marjorie you have right, that patch fail now because someone else did
> another patch that has the same functionality. So that one not is usable
> anymore.

Ah, that explains. I am closing the patch, please reopen if I missed something.
Comment 14 Marjorie Barry-Vila 2022-03-08 18:22:05 UTC
(In reply to George Veranis from comment #12)
> Marjorie you have right, that patch fail now because someone else did
> another patch that has the same functionality. So that one not is usable
> anymore.

ok thanks
There is an another bug id to follow?

Regards
Marjorie
Comment 15 Katrin Fischer 2022-03-08 23:04:10 UTC
I have to admit, I didn't find the bug which added it right away, here it is: bug 29965

*** This bug has been marked as a duplicate of bug 29965 ***