We added this and want to make it available for others too.
Created attachment 120260 [details] [review] Bug 28247: Add a MARC preview column to to Authority search results table To test: 1) Do an authority search 2) Notice the MARC preview column 3) Click "Show" for some of the results. 4) Confirm that the correct details are shown. 5) Sign off.
Created attachment 120261 [details] [review] Bug 28247: Add a MARC preview column to to Authority search results table To test: 1) Do an authority search 2) Notice the MARC preview column 3) Click "Show" for some of the results. 4) Confirm that the correct details are shown. 5) Sign off. Changed position of the MARC preview column
Created attachment 121795 [details] [review] Bug 28247: Add a MARC preview column to to Authority search results table To test: 1) Do an authority search 2) Notice the MARC preview column 3) Click "Show" for some of the results. 4) Confirm that the correct details are shown. 5) Sign off. Signed-off-by: Salman Ali <salman@outaouais>
The "Heading type" and "MARC preview" headings are misaligned with regard to the contents of the table, so the "Show" button is under the "Heading type" column header. To be consistent with other areas of Koha I would ask that the button say "MARC preview." For instance, from the cataloging search results: <i class="fa fa-eye"></i> MARC preview Generally if there are other actions grouped in a menu like there are on the authority search results page I would say put any new actions in that menu too. However on this page the results is (for me at least) always quite narrow so there is plenty of room. I'm interested to hear what others think.
koha-testing-docker isn't working on my computer and I'm going on holiday, so I won't be able to complete this.
Created attachment 129206 [details] [review] Bug 28247: (folow up) Add a MARC preview action to Authority search results To test: 1) Do an authority search 2) On Actions button click to see the available actions and click on "MARC preview" action. 3) A modal window open and confirm that the correct details are shown.
*** Bug 15723 has been marked as a duplicate of this bug. ***
Created attachment 129236 [details] [review] Bug 28247: (folow up) Add a MARC preview action to Authority search results To test: 1) Do an authority search 2) On Actions button click to see the available actions and click on "MARC preview" action. 3) A modal window open and confirm that the correct details are shown. Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi>
(In reply to Samu Heiskanen from comment #8) > Created attachment 129236 [details] [review] [review] > Bug 28247: (folow up) Add a MARC preview action to Authority search results > > To test: > 1) Do an authority search > 2) On Actions button click to see the available actions and click on "MARC > preview" action. > 3) A modal window open and confirm that the correct details are shown. > > Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi> Hi, I just tested in a sandbox (21.12.00.016) (https://staff-bz28247.sandbox.bywatersolutions.com/) and 'Marc preview' appears twice in the Actions menu, is this normal? Regards Marjorie
Created attachment 131212 [details] Marc preview
(In reply to Marjorie Barry-Vila from comment #9) > (In reply to Samu Heiskanen from comment #8) > Hi, > > I just tested in a sandbox (21.12.00.016) > (https://staff-bz28247.sandbox.bywatersolutions.com/) and 'Marc preview' > appears twice in the Actions menu, is this normal? > > Regards > > Marjorie Hi Marjorie, please don't hesitate to set "Failed QA" - it sure sounds like we need to check this out!
Marjorie you have right, that patch fail now because someone else did another patch that has the same functionality. So that one not is usable anymore.
(In reply to George Veranis from comment #12) > Marjorie you have right, that patch fail now because someone else did > another patch that has the same functionality. So that one not is usable > anymore. Ah, that explains. I am closing the patch, please reopen if I missed something.
(In reply to George Veranis from comment #12) > Marjorie you have right, that patch fail now because someone else did > another patch that has the same functionality. So that one not is usable > anymore. ok thanks There is an another bug id to follow? Regards Marjorie
I have to admit, I didn't find the bug which added it right away, here it is: bug 29965 *** This bug has been marked as a duplicate of bug 29965 ***