Bug 28435

Summary: CanBookBeRenewed returns only a single status and falsely indicates renewal can be overridden
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, jonathan.druart, kyle.m.hall, martin.renvoize, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Nick Clemens (kidclamp) 2021-05-24 12:46:27 UTC 
Similar to bug 22866 - depending on system settings you may or may not be able to override a hold to renew an item.

For instance - if an item is on hold, and the renewal limit has been reached CanBookBeRenewed returns 'TooMany'

Checking the 'Override renewal restrictions' button makes the hold appear renewable.

Executing the renewal fails because of 'On hold'

Returning all status would allow us to sort which can be overridden and which cannot, however, there would be a performance cost for patrons with many checkouts.

We could also develop an API route to check when the override button is checked, calculating if renewal is possible with override and only allowing the checkbox if so.

Alternately, we could add a system preference to always return all statuses and allow the library to choose performance vs completeness of response.

I am not sure the bets path and am filing this bug for discussion.
Comment 1 Jonathan Druart 2021-06-07 10:15:46 UTC 
This made me think I tried "that" already on bug 25758.

Is it what you meant?

https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107894
Comment 2 Katrin Fischer 2023-07-01 09:31:59 UTC 
(In reply to Jonathan Druart from comment #1)
> This made me think I tried "that" already on bug 25758.
> 
> Is it what you meant?
> 
> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107894

Can this be marked as resolved with bug 25758 in Koha?
Comment 3 Jonathan Druart 2023-07-04 08:46:09 UTC 
(In reply to Katrin Fischer from comment #2)
> (In reply to Jonathan Druart from comment #1)
> > This made me think I tried "that" already on bug 25758.
> > 
> > Is it what you meant?
> > 
> > https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107894
> 
> Can this be marked as resolved with bug 25758 in Koha?

Yes.

*** This bug has been marked as a duplicate of bug 25758 ***