Bug 26440 - Not renewable Supersedes On Hold
Summary: Not renewable Supersedes On Hold
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low normal with 29 votes (vote)
Assignee: Didier Gautheron
QA Contact: Testopia
URL:
Keywords:
Depends on: 25758
Blocks:
  Show dependency treegraph
 
Reported: 2020-09-11 19:20 UTC by John Yorio
Modified: 2022-09-02 06:22 UTC (History)
11 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 26440: Prioritize 'on hold' over Not renewable' in Renew column (6.10 KB, patch)
2021-12-16 07:08 UTC, Didier Gautheron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description John Yorio 2020-09-11 19:20:21 UTC

    
Comment 1 John Yorio 2020-09-11 19:31:10 UTC
In 18.11, and possibly prior, if a checked out item, with no remaining renewals, had a hold placed on it, the Renew column would show "On hold" as a link.

In 19.11 and 20.05, the same situation, it shows "Not renewable" with a count of 0 of [the max renewals value] remaining.

The "On hold" message was of more helpful to staff in determining whether or not they would try to force a renewal.
Comment 2 Lisette Scheer 2020-09-14 23:48:13 UTC
I agree that this was very helpful for staff. I confirmed that it doesn't work with item or record level holds. 
Lisette
Comment 3 Agnes Rivers-Moore 2020-09-17 22:32:16 UTC
I reported this one to John on behalf of several Koha libraries. Staff definitely prefer seeing ON HOLD as the primary message indicating not renewable in a patron's checkout list. 
When people ask if they can renew, it is much more important for staff to see that someone else is waiting, rather than the message that the renewal limit was reached.
The ON HOLD link allowed staff to check who is next and how many people are waiting very easily.  Please reinstate that as it was in previous versions. Thank you!
Comment 4 Katrin Fischer 2020-09-20 22:37:53 UTC
I think bug 25758 is quite similar, but not sure if it fixes this bug as well. Adding as a see also.
Comment 5 Lisette Scheer 2021-04-09 00:01:35 UTC
(In reply to Katrin Fischer from comment #4)
> I think bug 25758 is quite similar, but not sure if it fixes this bug as
> well. Adding as a see also.

We are on 20.05.09 and are still seeing this, so I don't believe it was fixed.
Comment 6 Didier Gautheron 2021-12-16 07:08:55 UTC
Created attachment 128586 [details] [review]
Bug 26440: Prioritize 'on hold' over Not renewable' in Renew column
Comment 7 Didier Gautheron 2021-12-16 07:11:09 UTC
It's still an issue in 20.11.

Attached the patch we are using.
Comment 8 Jason Robb 2022-01-27 18:53:54 UTC
We are currently on 21.05.08 and still running into confusion with this.

We prefer the "On hold" message to take priority as well.

"Not renewable" allows staff to attempt to override the renewal which fails. The renewal failure message is not persistent and disappears very quickly, so it is easy to overlook that the renewal failed altogether.
Comment 9 Fridolin Somers 2022-07-29 06:29:48 UTC
Is patch ready for signoff ?
Comment 10 Emmi Takkinen 2022-08-02 08:41:07 UTC
Patch no longer applies.
Comment 11 Nick Clemens 2022-09-02 06:22:51 UTC
(In reply to Didier Gautheron from comment #6)
> Created attachment 128586 [details] [review] [review]
> Bug 26440: Prioritize 'on hold' over Not renewable' in Renew column

This patch will have an impact on performance.

CheckReserves is a complicated routine that checks many aspects or reserves/holdability and for borrowers with many items, or titles with many holds, we will spend a lot of time in this routine and slow the loading of the patron.

At a minimum, I would want to see a system preference here, so larger systems can prioritize performance, and others can prioritize 'On hold' message.

I also think we should tackle the issue that when a renewal is attempted, the table is reloaded, rather than just the rows updated as needed and new messages lost