Bug 22866 - ItemsDeniedRenewal cannot be overriden
Summary: ItemsDeniedRenewal cannot be overriden
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 15494
Blocks:
  Show dependency treegraph
 
Reported: 2019-05-07 20:20 UTC by Andrew Fuerste-Henry
Modified: 2021-10-22 11:58 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 22866 - Allow override of renewals denied by ItemsDeniedRenewal (1.77 KB, patch)
2021-08-31 11:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 22866: Allow override of renewals denied by ItemsDeniedRenewal (1.77 KB, patch)
2021-08-31 11:51 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 22866: Allow override of renewals denied by ItemsDeniedRenewal (1.82 KB, patch)
2021-08-31 12:23 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 22866: Allow override of renewals denied by ItemsDeniedRenewal (1.88 KB, patch)
2021-08-31 17:35 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 22866: Add syspref (3.96 KB, patch)
2021-09-01 12:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 22866: Allow override of renewals denied by ItemsDeniedRenewal (1.93 KB, patch)
2021-10-22 11:58 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 22866: Add syspref (4.00 KB, patch)
2021-10-22 11:58 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2019-05-07 20:20:54 UTC
To Test:
- Create a circ rule for patron category Y and itemtype X
- Block renewal of itemtype X using ItemsDeniedRenewal
- Confirm AllowRenewalLimitOverride is set to Allow
- Check item of itemtype X out to patron of category Y
- See that circulation.pl shows "renewal denied by syspref"
- Click the checkbox for "Override renewal limit"
- See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed
- Attempt to renew item
- See error "Renew failed: item_denied_renewal"

Ideally, one could override renewal blocks due to ItemsDeniedRenewal. Failing that, we should at least amend the confusing behavior in which is looks like you'll be able to override but then you receive an error.
Comment 1 Esther Melander 2021-08-06 20:30:17 UTC
This bug popped up recently in 20.05.13.

Our consortium wanted to block renewals for Long Overdue Lost items in the OPAC. We changed the ItemsDeniedRenewal setting so there are no custom rules, which somehow prevents Long Overdue Lost items from being renewed in the OPAC. However, this also blocked renewal in the staff client. All other combinations of patron and item categories appear to be able to renew. Only items with the item status of Long Overdue Lost is blocked - at least as far we can determine.

For a staff account with superlibrarian permissions, or specifically the override blocked renewals permission the override returns an error.

To test:
- Use a staff account with permission to override blocked renewals
- Remove custom rules for ItemsDeniedRenewal
- Locate a patron with Long Overdue Lost items.
- Check the box to override renewal restrictions
- Select items that are Long Overdue Lost and click renew items.

System will return : Renew failed: item_denied_renewal

Koha should allow the renewal of items with the status of Long Overdue Lost with the override renewal function.
Comment 2 Esther Melander 2021-08-06 20:41:15 UTC
Our Consortium has two version of Lost - Lost and Long Overdue Lost. Both status's are not able to be overridden.
Comment 3 Esther Melander 2021-08-06 21:48:12 UTC
I need to revise the above steps.

To test:
- Use a staff account with permission to override blocked renewals
- Add custom rule for ItemsDeniedRenewal, itemlost: [1,2]
- Locate a patron with Long Overdue Lost items.
- Check the box to override renewal restrictions
- Select items that are Long Overdue Lost and click renew items.

System will return : Renew failed: item_denied_renewal
Comment 4 Andrew Fuerste-Henry 2021-08-17 12:29:34 UTC
I marked this an enhancement when I filed it. In retrospect, I believe it is a bug.
Comment 5 Kyle M Hall 2021-08-31 11:50:22 UTC
Created attachment 124272 [details] [review]
Bug 22866 - Allow override of renewals denied by ItemsDeniedRenewal

Test Plan:
1) Create a circ rule for patron category Y and itemtype X
2) Block renewal of itemtype X using ItemsDeniedRenewal
3) Confirm AllowRenewalLimitOverride is set to Allow
4) Check item of itemtype X out to patron of category Y
5) See that circulation.pl shows "renewal denied by syspref"
6) Click the checkbox for "Override renewal limit"
7) See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed
8) Attempt to renew item
9) See error "Renew failed: item_denied_renewal"
10) Apply this patch
11) Restart all the things!
12) Attempt to renew the item via override again
13) The renewal is a success!
Comment 6 Kyle M Hall 2021-08-31 11:51:01 UTC
Created attachment 124273 [details] [review]
Bug 22866: Allow override of renewals denied by ItemsDeniedRenewal

Test Plan:
1) Create a circ rule for patron category Y and itemtype X
2) Block renewal of itemtype X using ItemsDeniedRenewal
3) Confirm AllowRenewalLimitOverride is set to Allow
4) Check item of itemtype X out to patron of category Y
5) See that circulation.pl shows "renewal denied by syspref"
6) Click the checkbox for "Override renewal limit"
7) See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed
8) Attempt to renew item
9) See error "Renew failed: item_denied_renewal"
10) Apply this patch
11) Restart all the things!
12) Attempt to renew the item via override again
13) The renewal is a success!
Comment 7 Andrew Fuerste-Henry 2021-08-31 12:23:34 UTC
Created attachment 124277 [details] [review]
Bug 22866: Allow override of renewals denied by ItemsDeniedRenewal

Test Plan:
1) Create a circ rule for patron category Y and itemtype X
2) Block renewal of itemtype X using ItemsDeniedRenewal
3) Confirm AllowRenewalLimitOverride is set to Allow
4) Check item of itemtype X out to patron of category Y
5) See that circulation.pl shows "renewal denied by syspref"
6) Click the checkbox for "Override renewal limit"
7) See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed
8) Attempt to renew item
9) See error "Renew failed: item_denied_renewal"
10) Apply this patch
11) Restart all the things!
12) Attempt to renew the item via override again
13) The renewal is a success!

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 8 Andrew Fuerste-Henry 2021-08-31 17:35:05 UTC
Created attachment 124312 [details] [review]
Bug 22866: Allow override of renewals denied by ItemsDeniedRenewal

Test Plan:
1) Create a circ rule for patron category Y and itemtype X
2) Block renewal of itemtype X using ItemsDeniedRenewal
3) Confirm AllowRenewalLimitOverride is set to Allow
4) Check item of itemtype X out to patron of category Y
5) See that circulation.pl shows "renewal denied by syspref"
6) Click the checkbox for "Override renewal limit"
7) See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed
8) Attempt to renew item
9) See error "Renew failed: item_denied_renewal"
10) Apply this patch
11) Restart all the things!
12) Attempt to renew the item via override again
13) The renewal is a success!

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Esther Melander <estherm@sodaspringsid.com>
Comment 9 Nick Clemens 2021-08-31 17:41:59 UTC
This one should have another syspref to enable this behvaiour - some libraries do not wish the items denied renewal to be overridden
Comment 10 Kyle M Hall 2021-09-01 12:24:26 UTC
Created attachment 124324 [details] [review]
Bug 22866: Add syspref
Comment 11 Nick Clemens 2021-10-22 11:58:20 UTC
Created attachment 126750 [details] [review]
Bug 22866: Allow override of renewals denied by ItemsDeniedRenewal

Test Plan:
1) Create a circ rule for patron category Y and itemtype X
2) Block renewal of itemtype X using ItemsDeniedRenewal
3) Confirm AllowRenewalLimitOverride is set to Allow
4) Check item of itemtype X out to patron of category Y
5) See that circulation.pl shows "renewal denied by syspref"
6) Click the checkbox for "Override renewal limit"
7) See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed
8) Attempt to renew item
9) See error "Renew failed: item_denied_renewal"
10) Apply this patch
11) Restart all the things!
12) Attempt to renew the item via override again
13) The renewal is a success!

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Esther Melander <estherm@sodaspringsid.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 12 Nick Clemens 2021-10-22 11:58:23 UTC
Created attachment 126751 [details] [review]
Bug 22866: Add syspref

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>