To Test: - Create a circ rule for patron category Y and itemtype X - Block renewal of itemtype X using ItemsDeniedRenewal - Confirm AllowRenewalLimitOverride is set to Allow - Check item of itemtype X out to patron of category Y - See that circulation.pl shows "renewal denied by syspref" - Click the checkbox for "Override renewal limit" - See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed - Attempt to renew item - See error "Renew failed: item_denied_renewal" Ideally, one could override renewal blocks due to ItemsDeniedRenewal. Failing that, we should at least amend the confusing behavior in which is looks like you'll be able to override but then you receive an error.
This bug popped up recently in 20.05.13. Our consortium wanted to block renewals for Long Overdue Lost items in the OPAC. We changed the ItemsDeniedRenewal setting so there are no custom rules, which somehow prevents Long Overdue Lost items from being renewed in the OPAC. However, this also blocked renewal in the staff client. All other combinations of patron and item categories appear to be able to renew. Only items with the item status of Long Overdue Lost is blocked - at least as far we can determine. For a staff account with superlibrarian permissions, or specifically the override blocked renewals permission the override returns an error. To test: - Use a staff account with permission to override blocked renewals - Remove custom rules for ItemsDeniedRenewal - Locate a patron with Long Overdue Lost items. - Check the box to override renewal restrictions - Select items that are Long Overdue Lost and click renew items. System will return : Renew failed: item_denied_renewal Koha should allow the renewal of items with the status of Long Overdue Lost with the override renewal function.
Our Consortium has two version of Lost - Lost and Long Overdue Lost. Both status's are not able to be overridden.
I need to revise the above steps. To test: - Use a staff account with permission to override blocked renewals - Add custom rule for ItemsDeniedRenewal, itemlost: [1,2] - Locate a patron with Long Overdue Lost items. - Check the box to override renewal restrictions - Select items that are Long Overdue Lost and click renew items. System will return : Renew failed: item_denied_renewal
I marked this an enhancement when I filed it. In retrospect, I believe it is a bug.
Created attachment 124272 [details] [review] Bug 22866 - Allow override of renewals denied by ItemsDeniedRenewal Test Plan: 1) Create a circ rule for patron category Y and itemtype X 2) Block renewal of itemtype X using ItemsDeniedRenewal 3) Confirm AllowRenewalLimitOverride is set to Allow 4) Check item of itemtype X out to patron of category Y 5) See that circulation.pl shows "renewal denied by syspref" 6) Click the checkbox for "Override renewal limit" 7) See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed 8) Attempt to renew item 9) See error "Renew failed: item_denied_renewal" 10) Apply this patch 11) Restart all the things! 12) Attempt to renew the item via override again 13) The renewal is a success!
Created attachment 124273 [details] [review] Bug 22866: Allow override of renewals denied by ItemsDeniedRenewal Test Plan: 1) Create a circ rule for patron category Y and itemtype X 2) Block renewal of itemtype X using ItemsDeniedRenewal 3) Confirm AllowRenewalLimitOverride is set to Allow 4) Check item of itemtype X out to patron of category Y 5) See that circulation.pl shows "renewal denied by syspref" 6) Click the checkbox for "Override renewal limit" 7) See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed 8) Attempt to renew item 9) See error "Renew failed: item_denied_renewal" 10) Apply this patch 11) Restart all the things! 12) Attempt to renew the item via override again 13) The renewal is a success!
Created attachment 124277 [details] [review] Bug 22866: Allow override of renewals denied by ItemsDeniedRenewal Test Plan: 1) Create a circ rule for patron category Y and itemtype X 2) Block renewal of itemtype X using ItemsDeniedRenewal 3) Confirm AllowRenewalLimitOverride is set to Allow 4) Check item of itemtype X out to patron of category Y 5) See that circulation.pl shows "renewal denied by syspref" 6) Click the checkbox for "Override renewal limit" 7) See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed 8) Attempt to renew item 9) See error "Renew failed: item_denied_renewal" 10) Apply this patch 11) Restart all the things! 12) Attempt to renew the item via override again 13) The renewal is a success! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 124312 [details] [review] Bug 22866: Allow override of renewals denied by ItemsDeniedRenewal Test Plan: 1) Create a circ rule for patron category Y and itemtype X 2) Block renewal of itemtype X using ItemsDeniedRenewal 3) Confirm AllowRenewalLimitOverride is set to Allow 4) Check item of itemtype X out to patron of category Y 5) See that circulation.pl shows "renewal denied by syspref" 6) Click the checkbox for "Override renewal limit" 7) See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed 8) Attempt to renew item 9) See error "Renew failed: item_denied_renewal" 10) Apply this patch 11) Restart all the things! 12) Attempt to renew the item via override again 13) The renewal is a success! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Esther Melander <estherm@sodaspringsid.com>
This one should have another syspref to enable this behvaiour - some libraries do not wish the items denied renewal to be overridden
Created attachment 124324 [details] [review] Bug 22866: Add syspref
Created attachment 126750 [details] [review] Bug 22866: Allow override of renewals denied by ItemsDeniedRenewal Test Plan: 1) Create a circ rule for patron category Y and itemtype X 2) Block renewal of itemtype X using ItemsDeniedRenewal 3) Confirm AllowRenewalLimitOverride is set to Allow 4) Check item of itemtype X out to patron of category Y 5) See that circulation.pl shows "renewal denied by syspref" 6) Click the checkbox for "Override renewal limit" 7) See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed 8) Attempt to renew item 9) See error "Renew failed: item_denied_renewal" 10) Apply this patch 11) Restart all the things! 12) Attempt to renew the item via override again 13) The renewal is a success! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Esther Melander <estherm@sodaspringsid.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 126751 [details] [review] Bug 22866: Add syspref Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
I have to admit, AllowRenewalItemsDeniedOverride reads a little strange to me, why not AllowItemsDeniedRenewalOverride to stick with the feature name? Not a blocker. ItemsDeniedRenewal in the pref description should be linked, I will provide a follow-up.
Created attachment 128709 [details] [review] Bug 22866: (QA follow-up) Link system preference in preference description
The override checkbox will only show if AllowRenewalLimitOverride is also set to "Allow", but this dependency is not clear from the preferences and might be unintended? As is the new preference alone will have no effect. How should this work in reference to the Override blocked renewals (override_renewals) permission? Can you please clarify?