Bug 28449

Summary: Link from basket summary to invoice for an order line
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: AcquisitionsAssignee: Bugs List <koha-bugs>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: andrew, barbara.johnson, bugzilla, caroline.cyr-la-rose, fridolin.somers, Laura.escamilla, lucas, martin.renvoize, michaela.sieber, nengard
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/859
Text to go in the release notes:
This adds a new column 'Invoice' to the table of order lines on the basket summary page. It contains the invoicenumber for received order lines and is linked to the invoice if the staff user has the edit_invoices permission.
Version(s) released in:
23.11.00
Circulation function:
Bug Depends on: 34618    
Bug Blocks:    
Attachments: Bug 28449: Add column with invoice number to basket summary page
Bug 28449: Add column with invoice number to basket summary page
Bug 28449: Add column with invoice number to basket summary page
Bug 28449: Add column with invoice number to basket summary page
Bug 28449: Add column with invoice number to basket summary page
Bug 28449: Add column with invoice number to basket summary page
Bug 28449: Add column with invoice number to basket summary page

Description Katrin Fischer 2021-05-25 14:27:13 UTC
It would be nice if there was a link from the basket summary page to the invoice linked to an order line.

We could add a new column for the invoice number that could be hidden by default for libraries not interested in this feature.

An alternative could be linking the "(received)" information shown in front of the title.
Comment 1 Andrew Fuerste-Henry 2021-06-24 18:38:50 UTC
*** Bug 14090 has been marked as a duplicate of this bug. ***
Comment 2 Andrew Fuerste-Henry 2021-06-24 18:40:32 UTC
+1 on this. Currently on needs to follow a needlessly cumbersome chain of links from the basket to the bib to the invoice. There's no reason not to make that easier. I'm in favor of either of Katrin's options (a new column or a link off of the "received" note).
Comment 3 Barbara Johnson 2021-08-16 20:02:33 UTC
+1 Yes, this does require a lot of clicks.  I think a new column displaying the invoice number and a link to the actual invoice would be great.  There are times when we need to see the invoice but sometimes we just need to have the invoice number.
Comment 4 Katrin Fischer 2021-08-16 20:03:50 UTC
(In reply to Barbara Johnson from comment #3)
> +1 Yes, this does require a lot of clicks.  I think a new column displaying
> the invoice number and a link to the actual invoice would be great.  There
> are times when we need to see the invoice but sometimes we just need to have
> the invoice number.

Barbara, just want to take this chance to say thank you for your sign-offs and commenting on bugs - much appreciated!
Comment 5 Michaela Sieber 2023-07-31 17:13:44 UTC
+1
Comment 6 Katrin Fischer 2023-09-08 15:41:18 UTC
Created attachment 155442 [details] [review]
Bug 28449: Add column with invoice number to basket summary page

At the moment it's quite a lot of clicks to get from the basket
summary to the invoice something was received in. This adds a nice
shortcut by creating a new column for the invoicenumber in the basket
summary table.

To test:
* Make sure you have a basket with some received and unreceived
  order lines
* Verify that the (received) shows for your received lines
* Verify no invoice number or link to it in sight
* Apply patch
* Verify that there is now a column for the Invoice containing
  the invoice number as a link to the invoice
* Test with a staff patron, that doesn't have edit_invoices permission
* Verify that now instead of a link you see the invoice number as text

Be happy, sign off ;)

Note: this doesn't change the CSV export. The way the CSV is built is
quite different to the summary table, so it would be better handled
in a separate bug/patch. The columns are already quite different!
Comment 7 Katrin Fischer 2023-09-08 15:46:14 UTC
Created attachment 155443 [details] [review]
Bug 28449: Add column with invoice number to basket summary page

At the moment it's quite a lot of clicks to get from the basket
summary to the invoice something was received in. This adds a nice
shortcut by creating a new column for the invoicenumber in the basket
summary table.

To test:
* Make sure you have a basket with some received and unreceived
  order lines
* Verify that the (received) shows for your received lines
* Verify no invoice number or link to it in sight
* Apply patch
* Verify that there is now a column for the Invoice containing
  the invoice number as a link to the invoice
* Test with a staff patron, that doesn't have edit_invoices permission
* Verify that now instead of a link you see the invoice number as text

Be happy, sign off ;)

Note: this doesn't change the CSV export. The way the CSV is built is
quite different to the summary table, so it would be better handled
in a separate bug/patch. The columns are already quite different!
Comment 8 Laura Escamilla 2023-09-08 17:25:29 UTC
Created attachment 155452 [details] [review]
Bug 28449: Add column with invoice number to basket summary page

At the moment it's quite a lot of clicks to get from the basket
summary to the invoice something was received in. This adds a nice
shortcut by creating a new column for the invoicenumber in the basket
summary table.

To test:
* Make sure you have a basket with some received and unreceived
  order lines
* Verify that the (received) shows for your received lines
* Verify no invoice number or link to it in sight
* Apply patch
* Verify that there is now a column for the Invoice containing
  the invoice number as a link to the invoice
* Test with a staff patron, that doesn't have edit_invoices permission
* Verify that now instead of a link you see the invoice number as text

Be happy, sign off ;)

Note: this doesn't change the CSV export. The way the CSV is built is
quite different to the summary table, so it would be better handled
in a separate bug/patch. The columns are already quite different!

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 9 PTFS Europe Sandboxes 2023-09-08 17:36:52 UTC
Created attachment 155454 [details] [review]
Bug 28449: Add column with invoice number to basket summary page

At the moment it's quite a lot of clicks to get from the basket
summary to the invoice something was received in. This adds a nice
shortcut by creating a new column for the invoicenumber in the basket
summary table.

To test:
* Make sure you have a basket with some received and unreceived
  order lines
* Verify that the (received) shows for your received lines
* Verify no invoice number or link to it in sight
* Apply patch
* Verify that there is now a column for the Invoice containing
  the invoice number as a link to the invoice
* Test with a staff patron, that doesn't have edit_invoices permission
* Verify that now instead of a link you see the invoice number as text

Be happy, sign off ;)

Note: this doesn't change the CSV export. The way the CSV is built is
quite different to the summary table, so it would be better handled
in a separate bug/patch. The columns are already quite different!

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 10 Katrin Fischer 2023-09-09 11:58:12 UTC
Happy to see this hit a nerve :) I'll merge the sign-off lines so we have a patch with both. Thank you Laura and Michaela!
Comment 11 Katrin Fischer 2023-09-11 08:34:39 UTC
Created attachment 155473 [details] [review]
Bug 28449: Add column with invoice number to basket summary page

At the moment it's quite a lot of clicks to get from the basket
summary to the invoice something was received in. This adds a nice
shortcut by creating a new column for the invoicenumber in the basket
summary table.

To test:
* Make sure you have a basket with some received and unreceived
  order lines
* Verify that the (received) shows for your received lines
* Verify no invoice number or link to it in sight
* Apply patch
* Verify that there is now a column for the Invoice containing
  the invoice number as a link to the invoice
* Test with a staff patron, that doesn't have edit_invoices permission
* Verify that now instead of a link you see the invoice number as text

Be happy, sign off ;)

Note: this doesn't change the CSV export. The way the CSV is built is
quite different to the summary table, so it would be better handled
in a separate bug/patch. The columns are already quite different!

Sponsored-by: The Research University in the Helmholtz Association (KIT)

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 12 Katrin Fischer 2023-09-11 08:35:36 UTC
* Rebased on top of the very similar bug 34618
* Added 'Sponsored by' line
* Made sure both Michaela's and Laura's SO lines are present
Comment 13 Martin Renvoize (ashimema) 2023-09-11 11:24:17 UTC
Created attachment 155477 [details] [review]
Bug 28449: Add column with invoice number to basket summary page

At the moment it's quite a lot of clicks to get from the basket
summary to the invoice something was received in. This adds a nice
shortcut by creating a new column for the invoicenumber in the basket
summary table.

To test:
* Make sure you have a basket with some received and unreceived
  order lines
* Verify that the (received) shows for your received lines
* Verify no invoice number or link to it in sight
* Apply patch
* Verify that there is now a column for the Invoice containing
  the invoice number as a link to the invoice
* Test with a staff patron, that doesn't have edit_invoices permission
* Verify that now instead of a link you see the invoice number as text

Be happy, sign off ;)

Note: this doesn't change the CSV export. The way the CSV is built is
quite different to the summary table, so it would be better handled
in a separate bug/patch. The columns are already quite different!

Sponsored-by: The Research University in the Helmholtz Association (KIT)

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 14 Martin Renvoize (ashimema) 2023-09-11 11:24:43 UTC
Simple and very useful patch.  Working well and passing QA scripts.

Passing QA
Comment 15 Emily-Rose Francoeur 2023-09-12 18:56:12 UTC
Created attachment 155570 [details] [review]
Bug 28449: Add column with invoice number to basket summary page

At the moment it's quite a lot of clicks to get from the basket
summary to the invoice something was received in. This adds a nice
shortcut by creating a new column for the invoicenumber in the basket
summary table.

To test:
* Make sure you have a basket with some received and unreceived
  order lines
* Verify that the (received) shows for your received lines
* Verify no invoice number or link to it in sight
* Apply patch
* Verify that there is now a column for the Invoice containing
  the invoice number as a link to the invoice
* Test with a staff patron, that doesn't have edit_invoices permission
* Verify that now instead of a link you see the invoice number as text

Be happy, sign off ;)

Note: this doesn't change the CSV export. The way the CSV is built is
quite different to the summary table, so it would be better handled
in a separate bug/patch. The columns are already quite different!

Sponsored-by: The Research University in the Helmholtz Association (KIT)

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Comment 16 Martin Renvoize (ashimema) 2023-09-12 19:06:23 UTC
Hmm, what's happened here.. we appear to have lost the QA. Did the latch get a rebase or something during the last signoff?
Comment 17 Katrin Fischer 2023-09-12 19:46:40 UTC
I think Emily just picked from the wrong queue :)
Comment 18 Tomás Cohen Arazi (tcohen) 2023-09-25 13:49:18 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 19 Fridolin Somers 2023-09-25 19:25:49 UTC
Enhancement not pushed to 23.05.x