It would be nice if there was a link from the basket summary page to the invoice linked to an order line. We could add a new column for the invoice number that could be hidden by default for libraries not interested in this feature. An alternative could be linking the "(received)" information shown in front of the title.
*** Bug 14090 has been marked as a duplicate of this bug. ***
+1 on this. Currently on needs to follow a needlessly cumbersome chain of links from the basket to the bib to the invoice. There's no reason not to make that easier. I'm in favor of either of Katrin's options (a new column or a link off of the "received" note).
+1 Yes, this does require a lot of clicks. I think a new column displaying the invoice number and a link to the actual invoice would be great. There are times when we need to see the invoice but sometimes we just need to have the invoice number.
(In reply to Barbara Johnson from comment #3) > +1 Yes, this does require a lot of clicks. I think a new column displaying > the invoice number and a link to the actual invoice would be great. There > are times when we need to see the invoice but sometimes we just need to have > the invoice number. Barbara, just want to take this chance to say thank you for your sign-offs and commenting on bugs - much appreciated!
+1
Created attachment 155442 [details] [review] Bug 28449: Add column with invoice number to basket summary page At the moment it's quite a lot of clicks to get from the basket summary to the invoice something was received in. This adds a nice shortcut by creating a new column for the invoicenumber in the basket summary table. To test: * Make sure you have a basket with some received and unreceived order lines * Verify that the (received) shows for your received lines * Verify no invoice number or link to it in sight * Apply patch * Verify that there is now a column for the Invoice containing the invoice number as a link to the invoice * Test with a staff patron, that doesn't have edit_invoices permission * Verify that now instead of a link you see the invoice number as text Be happy, sign off ;) Note: this doesn't change the CSV export. The way the CSV is built is quite different to the summary table, so it would be better handled in a separate bug/patch. The columns are already quite different!
Created attachment 155443 [details] [review] Bug 28449: Add column with invoice number to basket summary page At the moment it's quite a lot of clicks to get from the basket summary to the invoice something was received in. This adds a nice shortcut by creating a new column for the invoicenumber in the basket summary table. To test: * Make sure you have a basket with some received and unreceived order lines * Verify that the (received) shows for your received lines * Verify no invoice number or link to it in sight * Apply patch * Verify that there is now a column for the Invoice containing the invoice number as a link to the invoice * Test with a staff patron, that doesn't have edit_invoices permission * Verify that now instead of a link you see the invoice number as text Be happy, sign off ;) Note: this doesn't change the CSV export. The way the CSV is built is quite different to the summary table, so it would be better handled in a separate bug/patch. The columns are already quite different!
Created attachment 155452 [details] [review] Bug 28449: Add column with invoice number to basket summary page At the moment it's quite a lot of clicks to get from the basket summary to the invoice something was received in. This adds a nice shortcut by creating a new column for the invoicenumber in the basket summary table. To test: * Make sure you have a basket with some received and unreceived order lines * Verify that the (received) shows for your received lines * Verify no invoice number or link to it in sight * Apply patch * Verify that there is now a column for the Invoice containing the invoice number as a link to the invoice * Test with a staff patron, that doesn't have edit_invoices permission * Verify that now instead of a link you see the invoice number as text Be happy, sign off ;) Note: this doesn't change the CSV export. The way the CSV is built is quite different to the summary table, so it would be better handled in a separate bug/patch. The columns are already quite different! Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 155454 [details] [review] Bug 28449: Add column with invoice number to basket summary page At the moment it's quite a lot of clicks to get from the basket summary to the invoice something was received in. This adds a nice shortcut by creating a new column for the invoicenumber in the basket summary table. To test: * Make sure you have a basket with some received and unreceived order lines * Verify that the (received) shows for your received lines * Verify no invoice number or link to it in sight * Apply patch * Verify that there is now a column for the Invoice containing the invoice number as a link to the invoice * Test with a staff patron, that doesn't have edit_invoices permission * Verify that now instead of a link you see the invoice number as text Be happy, sign off ;) Note: this doesn't change the CSV export. The way the CSV is built is quite different to the summary table, so it would be better handled in a separate bug/patch. The columns are already quite different! Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Happy to see this hit a nerve :) I'll merge the sign-off lines so we have a patch with both. Thank you Laura and Michaela!
Created attachment 155473 [details] [review] Bug 28449: Add column with invoice number to basket summary page At the moment it's quite a lot of clicks to get from the basket summary to the invoice something was received in. This adds a nice shortcut by creating a new column for the invoicenumber in the basket summary table. To test: * Make sure you have a basket with some received and unreceived order lines * Verify that the (received) shows for your received lines * Verify no invoice number or link to it in sight * Apply patch * Verify that there is now a column for the Invoice containing the invoice number as a link to the invoice * Test with a staff patron, that doesn't have edit_invoices permission * Verify that now instead of a link you see the invoice number as text Be happy, sign off ;) Note: this doesn't change the CSV export. The way the CSV is built is quite different to the summary table, so it would be better handled in a separate bug/patch. The columns are already quite different! Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
* Rebased on top of the very similar bug 34618 * Added 'Sponsored by' line * Made sure both Michaela's and Laura's SO lines are present
Created attachment 155477 [details] [review] Bug 28449: Add column with invoice number to basket summary page At the moment it's quite a lot of clicks to get from the basket summary to the invoice something was received in. This adds a nice shortcut by creating a new column for the invoicenumber in the basket summary table. To test: * Make sure you have a basket with some received and unreceived order lines * Verify that the (received) shows for your received lines * Verify no invoice number or link to it in sight * Apply patch * Verify that there is now a column for the Invoice containing the invoice number as a link to the invoice * Test with a staff patron, that doesn't have edit_invoices permission * Verify that now instead of a link you see the invoice number as text Be happy, sign off ;) Note: this doesn't change the CSV export. The way the CSV is built is quite different to the summary table, so it would be better handled in a separate bug/patch. The columns are already quite different! Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Simple and very useful patch. Working well and passing QA scripts. Passing QA
Created attachment 155570 [details] [review] Bug 28449: Add column with invoice number to basket summary page At the moment it's quite a lot of clicks to get from the basket summary to the invoice something was received in. This adds a nice shortcut by creating a new column for the invoicenumber in the basket summary table. To test: * Make sure you have a basket with some received and unreceived order lines * Verify that the (received) shows for your received lines * Verify no invoice number or link to it in sight * Apply patch * Verify that there is now a column for the Invoice containing the invoice number as a link to the invoice * Test with a staff patron, that doesn't have edit_invoices permission * Verify that now instead of a link you see the invoice number as text Be happy, sign off ;) Note: this doesn't change the CSV export. The way the CSV is built is quite different to the summary table, so it would be better handled in a separate bug/patch. The columns are already quite different! Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Hmm, what's happened here.. we appear to have lost the QA. Did the latch get a rebase or something during the last signoff?
I think Emily just picked from the wrong queue :)
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x