Summary: | Table Settings should control Checked out by field in Checkout history | ||
---|---|---|---|
Product: | Koha | Reporter: | Sally <sally.healey> |
Component: | System Administration | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28858 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
21.11.00
|
Circulation function: | |
Bug Depends on: | 23916, 29218 | ||
Bug Blocks: | |||
Attachments: |
Bug 28859: Fix missing column setting
Bug 28859: Fix missing column setting Bug 28859: Correctly handle 'Checked out by' visibility Bug 28859: Fix missing column setting Bug 28859: Correctly handle 'Checked out by' visibility |
Description
Sally
2021-08-13 14:31:08 UTC
Caused by commit eb283d13fab70d8a32216a5bee8fb4a71e6d875e Bug 23916: Record and display item issuer Andrew, can you fix this please? *** Bug 28916 has been marked as a duplicate of this bug. *** Created attachment 124986 [details] [review] Bug 28859: Fix missing column setting This commit adds the missing checked_out_by column to columns_settings.yaml Test plan: - Follow the test plans in the bug description and note that the symptoms are no longer seen Created attachment 124990 [details] [review] Bug 28859: Fix missing column setting This commit adds the missing checked_out_by column to columns_settings.yaml Test plan: - Follow the test plans in the bug description and note that the symptoms are no longer seen Signed-off-by: Owen Leonard <oleonard@myacpl.org> I am sorry, but the table configuration is broken with this patch applied and the preference set to "don't record". Uncaught TypeError: b.settings()[0].aoColumns[d] is undefined Created attachment 126146 [details] [review] Bug 28859: Correctly handle 'Checked out by' visibility We must have the column in the table and let DT deal with the visibility. This patch hides the "Checked out by" column by default if RecordStaffUserOnCheckout is off, but the DT column settings is aware of its existence and the end user can still display the column. IMO that's the most optimal situation considering both maintenance and ergonomic. *** Bug 28858 has been marked as a duplicate of this bug. *** Created attachment 127030 [details] [review] Bug 28859: Fix missing column setting This commit adds the missing checked_out_by column to columns_settings.yaml Test plan: - Follow the test plans in the bug description and note that the symptoms are no longer seen Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 127031 [details] [review] Bug 28859: Correctly handle 'Checked out by' visibility We must have the column in the table and let DT deal with the visibility. This patch hides the "Checked out by" column by default if RecordStaffUserOnCheckout is off, but the DT column settings is aware of its existence and the end user can still display the column. IMO that's the most optimal situation considering both maintenance and ergonomic. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I tested the whole bug series together (and separately for the individual QA's). This all works as expected now, thanks for working through it Jonathan. Passing QA Pushed to master for 21.11, thanks to everybody involved! |