Summary: | Use modal for suspending holds until a date from the holds page | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Hold requests | Assignee: | Owen Leonard <oleonard> |
Status: | Patch doesn't apply --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 29060: Use modal for suspending holds until a date from the holds page
Bug 29060: Use modal for suspending holds until a date from the holds page Bug 29060: Use modal for suspending holds until a date from the holds page |
Description
Owen Leonard
2021-09-20 17:16:44 UTC
Created attachment 125078 [details] [review] Bug 29060: Use modal for suspending holds until a date from the holds page This patch modifies the way suspensions are handled when viewing the list of holds on a particular title. In particular, when AutoResumeSuspendedHolds is enabled the "suspend until" form field is hidden until the suspend button is clicked, when a modal window appears. This is consistent with the way it works when working with the list of holds on a patron record. The patch also converts the hold deletion button from an "X" image to a more-standard "Delete" button. To test, apply the patch and make sure AutoResumeSuspendedHolds is enabled. - Locate a title in the catalog with multiple holds. - View the holds on that title. In the list of holds you should see "Delete" and "Suspend" buttons in the last two columns of the tabel of holds. - Test that the "Delete" button works correctly, - Test the "Suspend" button. Clicking it should trigger a modal window where you can set a date for the hold to resume. - Submitting the form with a date should result in the page reloading and showing the hold as suspended until that date. - Submitting hte form without a date should result in the page reloading and showing the hold as suspended. - Test that the "Resume" button works to remove the suspension. - Disable AutoResumeSuspendedHolds. Now when you click the "Suspend" button you should not see the modal. The page should reload and the hold should be suspended without a resume date. Patch no longer applies 8-(.. Applying: Bug 29060: Use modal for suspending holds until a date from the holds page Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc M koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 29060: Use modal for suspending holds until a date from the holds page Created attachment 126446 [details] [review] Bug 29060: Use modal for suspending holds until a date from the holds page This patch modifies the way suspensions are handled when viewing the list of holds on a particular title. In particular, when AutoResumeSuspendedHolds is enabled the "suspend until" form field is hidden until the suspend button is clicked, when a modal window appears. This is consistent with the way it works when working with the list of holds on a patron record. The patch also converts the hold deletion button from an "X" image to a more-standard "Delete" button. To test, apply the patch and make sure AutoResumeSuspendedHolds is enabled. - Locate a title in the catalog with multiple holds. - View the holds on that title. In the list of holds you should see "Delete" and "Suspend" buttons in the last two columns of the tabel of holds. - Test that the "Delete" button works correctly, - Test the "Suspend" button. Clicking it should trigger a modal window where you can set a date for the hold to resume. - Submitting the form with a date should result in the page reloading and showing the hold as suspended until that date. - Submitting hte form without a date should result in the page reloading and showing the hold as suspended. - Test that the "Resume" button works to remove the suspension. - Disable AutoResumeSuspendedHolds. Now when you click the "Suspend" button you should not see the modal. The page should reload and the hold should be suspended without a resume date. Patch doesn't apply 8-(... Applying: Bug 29060: Use modal for suspending holds until a date from the holds page error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt). error: could not build fake ancestor Patch failed at 0001 Bug 29060: Use modal for suspending holds until a date from the holds page Created attachment 126480 [details] [review] Bug 29060: Use modal for suspending holds until a date from the holds page This patch modifies the way suspensions are handled when viewing the list of holds on a particular title. In particular, when AutoResumeSuspendedHolds is enabled the "suspend until" form field is hidden until the suspend button is clicked, when a modal window appears. This is consistent with the way it works when working with the list of holds on a patron record. The patch also converts the hold deletion button from an "X" image to a more-standard "Delete" button. To test, apply the patch and make sure AutoResumeSuspendedHolds is enabled. - Locate a title in the catalog with multiple holds. - View the holds on that title. In the list of holds you should see "Delete" and "Suspend" buttons in the last two columns of the tabel of holds. - Test that the "Delete" button works correctly, - Test the "Suspend" button. Clicking it should trigger a modal window where you can set a date for the hold to resume. - Submitting the form with a date should result in the page reloading and showing the hold as suspended until that date. - Submitting hte form without a date should result in the page reloading and showing the hold as suspended. - Test that the "Resume" button works to remove the suspension. - Disable AutoResumeSuspendedHolds. Now when you click the "Suspend" button you should not see the modal. The page should reload and the hold should be suspended without a resume date. Patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29060: Use modal for suspending holds until a date from the holds page Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc M koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 29060: Use modal for suspending holds until a date from the holds page *** Bug 23149 has been marked as a duplicate of this bug. *** |