Bug 29060 - Use modal for suspending holds until a date from the holds page
Summary: Use modal for suspending holds until a date from the holds page
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 23149 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-09-20 17:16 UTC by Owen Leonard
Modified: 2022-01-11 00:41 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 29060: Use modal for suspending holds until a date from the holds page (12.50 KB, patch)
2021-09-20 17:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 29060: Use modal for suspending holds until a date from the holds page (6.55 KB, patch)
2021-10-18 16:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 29060: Use modal for suspending holds until a date from the holds page (12.21 KB, patch)
2021-10-19 10:58 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2021-09-20 17:16:44 UTC
If you view the list of holds on a patron's checkout screen you can click the "Suspend" button to trigger a modal dialog where you can select a date after which the hold should resume.

I'd like to make the controls work the same way when viewing the list of holds on a title, e.g. /cgi-bin/koha/reserve/request.pl?biblionumber=XXX
Comment 1 Owen Leonard 2021-09-20 17:48:23 UTC Comment hidden (obsolete)
Comment 2 David Nind 2021-10-17 17:19:49 UTC
Patch no longer applies 8-(..

Applying: Bug 29060: Use modal for suspending holds until a date from the holds page
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
M	koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
error: Failed to merge in the changes.
Patch failed at 0001 Bug 29060: Use modal for suspending holds until a date from the holds page
Comment 3 Owen Leonard 2021-10-18 16:46:42 UTC Comment hidden (obsolete)
Comment 4 David Nind 2021-10-18 19:54:15 UTC
Patch doesn't apply 8-(...

Applying: Bug 29060: Use modal for suspending holds until a date from the holds page
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 29060: Use modal for suspending holds until a date from the holds page
Comment 5 Owen Leonard 2021-10-19 10:58:26 UTC
Created attachment 126480 [details] [review]
Bug 29060: Use modal for suspending holds until a date from the holds page

This patch modifies the way suspensions are handled when viewing the
list of holds on a particular title. In particular, when
AutoResumeSuspendedHolds is enabled the "suspend until" form field is
hidden until the suspend button is clicked, when a modal window appears.
This is consistent with the way it works when working with the list of
holds on a patron record.

The patch also converts the hold deletion button from an "X" image to a
more-standard "Delete" button.

To test, apply the patch and make sure AutoResumeSuspendedHolds is
enabled.

- Locate a title in the catalog with multiple holds.
- View the holds on that title. In the list of holds you should see
  "Delete" and "Suspend" buttons in the last two columns of the tabel of
  holds.
- Test that the "Delete" button works correctly,
- Test the "Suspend" button. Clicking it should trigger a modal window
  where you can set a date for the hold to resume.
  - Submitting the form with a date should result in the page reloading
    and showing the hold as suspended until that date.
  - Submitting hte form without a date should result in the page
    reloading and showing the hold as suspended.
- Test that the "Resume" button works to remove the suspension.
- Disable AutoResumeSuspendedHolds. Now when you click the "Suspend"
  button you should not see the modal. The page should reload and the
  hold should be suspended without a resume date.
Comment 6 David Nind 2021-12-05 17:01:59 UTC
Patch no longer applies 8-(..

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 29060: Use modal for suspending holds until a date from the holds page
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
M	koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
error: Failed to merge in the changes.
Patch failed at 0001 Bug 29060: Use modal for suspending holds until a date from the holds page
Comment 7 Owen Leonard 2022-01-10 14:05:17 UTC
*** Bug 23149 has been marked as a duplicate of this bug. ***
Comment 8 Fridolin Somers 2022-01-11 00:41:39 UTC
Please look at changes from Bug 29737 "Fix suspend from hold list"