Summary: | NumSavedReports system preference doesn't work | ||
---|---|---|---|
Product: | Koha | Reporter: | Sara Brown <sbrown> |
Component: | Reports | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | andrew, barbara.johnson, david, fridolin.somers, kyle, lucas, victor |
Version: | Main | Keywords: | Manual |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the saved reports page so that the NumSavedReports system preference works as intended - the number of reports listed should default to the value in the system preference (the initial default is 20).
|
Version(s) released in: |
22.05.00,21.11.01,21.05.08
|
Circulation function: | |||
Bug Depends on: | 23013 | ||
Bug Blocks: | 29530 | ||
Attachments: |
Bug 29488: make NumSavedReports work
Bug 29488: make NumSavedReports work Bug 29488: make NumSavedReports work |
Description
Sara Brown
2021-11-15 20:04:37 UTC
In dataTables version 1.10 we should use pageLength instead of iDisplayLength. https://datatables.net/reference/option/pageLength Koha is using 1.10.18 Created attachment 127677 [details] [review] Bug 29488: make NumSavedReports work 1. Have a bunch of saved reports 2. Try to use the sys pref NumSavedReports to limit how many show by default 3. It doesn't work 4. Apply patch 5. Try again, now it should work Created attachment 127698 [details] [review] Bug 29488: make NumSavedReports work 1. Have a bunch of saved reports 2. Try to use the sys pref NumSavedReports to limit how many show by default 3. It doesn't work 4. Apply patch 5. Try again, now it should work Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 127871 [details] [review] Bug 29488: make NumSavedReports work 1. Have a bunch of saved reports 2. Try to use the sys pref NumSavedReports to limit how many show by default 3. It doesn't work 4. Apply patch 5. Try again, now it should work Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.05, thanks to everybody involved! Pushed to 21.11.x for 21.11.01 Added Manual keyword for 22.05 bugs that I consider require documentation changes. See bug 29640 and the linked spreadsheet for additional details. Pushed to 21.05.x for 21.05.08 Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. |