Summary: | Add a test for GetTagsLabels | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Test Suite | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, kyle, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
Circulation function: | |||
Attachments: |
Bug 30446: Add a test for GetTagsLabels
Bug 30446: Add a test for GetTagsLabels Bug 30446: (follow-up) Remove warning |
Description
Marcel de Rooy
2022-04-04 11:46:26 UTC
Created attachment 132932 [details] [review] Bug 30446: Add a test for GetTagsLabels Moved from obsoleted bug 2222 on its own. Test plan: Run t/db_dependent/Authority/GetTagsLabels.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Adding self SO: only simple unit test. Why not a subtest of t/db_dependent/AuthoritiesMarc.t? (In reply to Jonathan Druart from comment #3) > Why not a subtest of t/db_dependent/AuthoritiesMarc.t? Arbitrary choice. There are more subtests in this subdirectory. At some point it is easier to have separate files than one big one. Although that one is still small. Created attachment 133460 [details] [review] Bug 30446: Add a test for GetTagsLabels Moved from obsoleted bug 2222 on its own. Test plan: Run t/db_dependent/AuthoritiesMarc_GetTagsLabels.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 133461 [details] [review] Bug 30446: (follow-up) Remove warning This patch removes a trivial warning caused by a parameter being compared to a literal but not being defined. Doing a $ git grep GetTagsLabels shows the change is safe as the function is always called with a value of either 0 or 1. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (In reply to Tomás Cohen Arazi from comment #6) Thx Pushed to master for 22.05, thanks to everybody involved [U+1F984] |