Summary: | Value builder for UNIMARC field 181 | ||
---|---|---|---|
Product: | Koha | Reporter: | Jérémy Breuillard <jeremy.breuillard> |
Component: | Cataloging | Assignee: | Jérémy Breuillard <jeremy.breuillard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, jeremy.breuillard, lucas, m.de.rooy, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506 | ||
Change sponsored?: | --- | Patch complexity: | Large patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement for UNIMARC field 181 adds value builders for subfields $a, $b, $c, and $2. These are based on the official UNIMARC codes.
|
Version(s) released in: |
22.11.00
|
Bug Depends on: | 29159 | ||
Bug Blocks: | |||
Attachments: |
Bug 30504: Value builder for field 181
MT 35334: Value builder for field 181 Bug 30504: Value builder for field 181 Bug 30504: Value builder for field 181 Bug 30504: Value builder for field 181 |
Description
Jérémy Breuillard
2022-04-11 10:20:23 UTC
Created attachment 133150 [details] [review] Bug 30504: Value builder for field 181 This patch provides values builders for the subfields $a, $b, $c and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 181 : it contains subfields $a, $b, $c & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a, $b, $c and $2 Created attachment 134429 [details] [review] MT 35334: Value builder for field 181 This patch provides values builders for the subfields $a, $b, $c and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 181 : it contains subfields $a, $b, $c & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a, $b, $c and $2 https://bugs.koha-community.org/show_bug.cgi?id=30504 Signed-off-by: David Nind <david@davidnind.com> Testing notes (using koha-testing-docker on master): - Click field 181's title to display subfields $b and $2 (their visibility is set to collapsed for the default framework) - Noted that $c has an authorised value list by default: I assume that libraries will remove this link if they want to use the value builder plugin (the authorised value list seems to take priority if it and value builder plugin are both selected) - I didn't try editing or creating a record a I am not familiar with UNIMARC and there seems to be a lot of required fields! I am not sure what happened when I signed off the patch. The original patch is listed and there is a new patch starting with MT 35334... I did my normal: - git so 1 - git bz attach -e 30504 HEAD I'm not sure how to fix this - I'm assuming it has something to do with how the patch is formatted. Jérémy: On your attachment on comment 1 when clicking on details, we can see in the patch content that the commit has the wrong ticket number. Even if in bugzilla the attachment has the right title. You need to do git commit --amend to change the commit message to have the right ticket number. (you need to apply the patch from here to have David's version to keep their signoff line) I marked as obsolete the oldest attachment here so only the one signed off by David remains. Created attachment 135122 [details] [review] Bug 30504: Value builder for field 181 This patch provides values builders for the subfields $a, $b, $c and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 181 : it contains subfields $a, $b, $c & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a, $b, $c and $2 Signed-off-by: David Nind <david@davidnind.com> (In reply to Victor Grousset/tuxayo from comment #5) > Jérémy: On your attachment on comment 1 when clicking on details, we can see > in the patch content that the commit has the wrong ticket number. Even if in > bugzilla the attachment has the right title. > > You need to do git commit --amend to change the commit message to have the > right ticket number. (you need to apply the patch from here to have David's > version to keep their signoff line) > > I marked as obsolete the oldest attachment here so only the one signed off > by David remains. Ok, thanks for the comment ! :) Created attachment 135163 [details] [review] Bug 30504: Value builder for field 181 This patch provides values builders for the subfields $a, $b, $c and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 181 : it contains subfields $a, $b, $c & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a, $b, $c and $2 Signed-off-by: David Nind <david@davidnind.com> Created attachment 139474 [details] [review] Bug 30504: Value builder for field 181 This patch provides values builders for the subfields $a, $b, $c and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 181 : it contains subfields $a, $b, $c & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a, $b, $c and $2 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! Enhancement will not be backported to 22.05.x |