Bug 30506 - Value builder for UNIMARC field 182
Summary: Value builder for UNIMARC field 182
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jérémy Breuillard
QA Contact: Testopia
URL:
Keywords:
Depends on: 29159
Blocks:
  Show dependency treegraph
 
Reported: 2022-04-11 12:04 UTC by Jérémy Breuillard
Modified: 2022-05-20 06:51 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement for UNIMARC field 182 adds value builders for subfields $a, $c, and $2. These are based on the official UNIMARC codes.
Version(s) released in:


Attachments
Bug 30506: Value builder for field 182 (17.87 KB, patch)
2022-04-11 12:09 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
MT 35336: Value builder for field 182 (17.90 KB, patch)
2022-04-30 01:25 UTC, David Nind
Details | Diff | Splinter Review
Bug 30506: Value builder for field 182 (17.87 KB, patch)
2022-05-18 14:05 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 30506: Value builder for field 182 (17.84 KB, patch)
2022-05-18 20:13 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jérémy Breuillard 2022-04-11 12:04:17 UTC
It could be easier to have plugins on each subfield for field $182 :
$a, $c and $2

The value builder plugins let you choose a alphanumeric code based on unimarc official documents and depending on the item you want to store in koha
Comment 1 Jérémy Breuillard 2022-04-11 12:09:37 UTC Comment hidden (obsolete)
Comment 2 David Nind 2022-04-30 01:25:54 UTC
Created attachment 134430 [details] [review]
MT 35336: Value builder for field 182

This patch provides values builders for the subfields $a, $c and $2. Those are unimarc official codes who help to
identify the kind of items
Test plan:
1)Go to Home > Cataloging > New record
2)Section 1 - field 182 : it contains subfields $a, $c & $2
3)Inputs are writable but notice that no plugins are suggested
4)Apply patch and repeat 1) to 3)
5)Values builders plugins are available for $a, $c and $2

https://bugs.koha-community.org/show_bug.cgi?id=30506

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2022-04-30 01:30:09 UTC
Testing notes (using koha-testing-docker on master):

- Click field 182's title to display subfield $2 (their visibility is set to collapsed for the default framework)

- Noted that subfields $a and $c have an authorised value list by default which need unlinking for the new value builders to work: I assume that libraries will remove these links if they want to use the value builder plugins (the authorised value list takes priority if both the authorised value list and the value builder plugin are both selected)

- I didn't try editing or creating a record as I am not familiar with UNIMARC and there seems to be a lot of required fields!
Comment 4 David Nind 2022-04-30 02:08:17 UTC
I am not sure what happened when I signed off the patch. 

The original patch is listed and there is a new patch starting with MT 35336...

I did my normal:
- git so 1
- git bz attach -e 30506 HEAD

I'm not sure how to fix this - I'm assuming it has something to do with how the patch is formatted.
Comment 5 Victor Grousset/tuxayo 2022-04-30 17:22:50 UTC
Same issue with the commit name as in bug 30504 comment 5
Comment 6 Jérémy Breuillard 2022-05-18 14:05:19 UTC
Created attachment 135117 [details] [review]
Bug 30506: Value builder for field 182

This patch provides values builders for the subfields $a, $c and $2. Those are unimarc official codes who help to
identify the kind of items
Test plan:
1)Go to Home > Cataloging > New record
2)Section 1 - field 182 : it contains subfields $a, $c & $2
3)Inputs are writable but notice that no plugins are suggested
4)Apply patch and repeat 1) to 3)
5)Values builders plugins are available for $a, $c and $2

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2022-05-18 20:05:38 UTC
Comment on attachment 134430 [details] [review]
MT 35336: Value builder for field 182

I've obsoleted the MT 35336 patch.
Comment 8 David Nind 2022-05-18 20:13:14 UTC
Created attachment 135164 [details] [review]
Bug 30506: Value builder for field 182

This patch provides values builders for the subfields $a, $c and $2. Those are unimarc official codes who help to
identify the kind of items
Test plan:
1)Go to Home > Cataloging > New record
2)Section 1 - field 182 : it contains subfields $a, $c & $2
3)Inputs are writable but notice that no plugins are suggested
4)Apply patch and repeat 1) to 3)
5)Values builders plugins are available for $a, $c and $2

Signed-off-by: David Nind <david@davidnind.com>