Summary: | Value builder for UNIMARC field 182 | ||
---|---|---|---|
Product: | Koha | Reporter: | Jérémy Breuillard <jeremy.breuillard> |
Component: | Cataloging | Assignee: | Jérémy Breuillard <jeremy.breuillard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, jeremy.breuillard, lucas, m.de.rooy, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504 | ||
Change sponsored?: | --- | Patch complexity: | Medium patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement for UNIMARC field 182 adds value builders for subfields $a, $c, and $2. These are based on the official UNIMARC codes.
|
Version(s) released in: |
22.11.00
|
Circulation function: | |||
Bug Depends on: | 29159 | ||
Bug Blocks: | |||
Attachments: |
Bug 30506: Value builder for field 182
MT 35336: Value builder for field 182 Bug 30506: Value builder for field 182 Bug 30506: Value builder for field 182 Bug 30506: Value builder for field 182 |
Description
Jérémy Breuillard
2022-04-11 12:04:17 UTC
Created attachment 133151 [details] [review] Bug 30506: Value builder for field 182 This patch provides values builders for the subfields $a, $c and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 182 : it contains subfields $a, $c & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a, $c and $2 Created attachment 134430 [details] [review] MT 35336: Value builder for field 182 This patch provides values builders for the subfields $a, $c and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 182 : it contains subfields $a, $c & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a, $c and $2 https://bugs.koha-community.org/show_bug.cgi?id=30506 Signed-off-by: David Nind <david@davidnind.com> Testing notes (using koha-testing-docker on master): - Click field 182's title to display subfield $2 (their visibility is set to collapsed for the default framework) - Noted that subfields $a and $c have an authorised value list by default which need unlinking for the new value builders to work: I assume that libraries will remove these links if they want to use the value builder plugins (the authorised value list takes priority if both the authorised value list and the value builder plugin are both selected) - I didn't try editing or creating a record as I am not familiar with UNIMARC and there seems to be a lot of required fields! I am not sure what happened when I signed off the patch. The original patch is listed and there is a new patch starting with MT 35336... I did my normal: - git so 1 - git bz attach -e 30506 HEAD I'm not sure how to fix this - I'm assuming it has something to do with how the patch is formatted. Same issue with the commit name as in bug 30504 comment 5 Created attachment 135117 [details] [review] Bug 30506: Value builder for field 182 This patch provides values builders for the subfields $a, $c and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 182 : it contains subfields $a, $c & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a, $c and $2 Signed-off-by: David Nind <david@davidnind.com> Comment on attachment 134430 [details] [review] MT 35336: Value builder for field 182 I've obsoleted the MT 35336 patch. Created attachment 135164 [details] [review] Bug 30506: Value builder for field 182 This patch provides values builders for the subfields $a, $c and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 182 : it contains subfields $a, $c & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a, $c and $2 Signed-off-by: David Nind <david@davidnind.com> Created attachment 139475 [details] [review] Bug 30506: Value builder for field 182 This patch provides values builders for the subfields $a, $c and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 182 : it contains subfields $a, $c & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a, $c and $2 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! Enhancement will not be in 22.05.x |