Summary: | Fix report author display in list of saved reports | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, kyle, m.de.rooy, martin.renvoize |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the display of report authors in the list of saved reports to remove the extra space before the comma (Lastname, Firstname was displaying as Lastname , Firstname).
|
Version(s) released in: |
22.05.00
|
Bug Depends on: | 30491 | ||
Bug Blocks: | 30651 | ||
Attachments: |
Bug 30632: Fix report author display in list of saved reports
Bug 30632: Fix report author display in list of saved reports Bug 30632: Fix report author display in list of saved reports |
Description
Katrin Fischer
2022-04-27 16:28:21 UTC
Created attachment 134281 [details] [review] Bug 30632: Fix report author display in list of saved reports This patch removes whitespace in the template around the markup of report author first name and surname. This prevents unwanted spaces in the output. To test, apply the patch and go to Reports -> Use saved. The display of report author should be like this: Leonard, Owen (123456) Instead of Leonard , Owen (20375) With all the patches for preferred name/middle name and such I was wondering if we could use patron-title.inc here. Is there a reason not to? I made this quick template fix because fixing it to use the patron-title include would require more complex updates to the way reports are queried. I certainly do not object if someone wants to take that route instead. Created attachment 134303 [details] [review] Bug 30632: Fix report author display in list of saved reports This patch removes whitespace in the template around the markup of report author first name and surname. This prevents unwanted spaces in the output. To test, apply the patch and go to Reports -> Use saved. The display of report author should be like this: Leonard, Owen (123456) Instead of Leonard , Owen (20375) Signed-off-by: David Nind <david@davidnind.com> Created attachment 134355 [details] [review] Bug 30632: Fix report author display in list of saved reports This patch removes whitespace in the template around the markup of report author first name and surname. This prevents unwanted spaces in the output. To test, apply the patch and go to Reports -> Use saved. The display of report author should be like this: Leonard, Owen (123456) Instead of Leonard , Owen (20375) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> I am ok with the simple fix. I am filing a new one to "switch" to the include. Pushed to master for 22.05, thanks to everybody involved 🦄 |