Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the saved report template (guided_reports_start.tt).
Created attachment 133895 [details] [review] Bug 30491: Convert saved reports tabs to Bootstrap This patch updates the saved reports page so that it uses Bootstrap tabs instead of jQueryUI. To test, apply the patch and go to Reports -> Use saved. - On the Saved Reports page you should see multiple tabs. - Each should look correct and work correctly. - Clicking each tab should result in the table of reports filtering correctly for that tab (Patrons tab showing only patrons reports). - If necessary, edit one or more reports so that they have a subgroup. - Confirm that each subgroup selector is correct for each tab, i.e. a subgroup created under "Catalog" should only be available under the Catalog tab.
Created attachment 133905 [details] [review] Bug 30491: Convert saved reports tabs to Bootstrap This patch updates the saved reports page so that it uses Bootstrap tabs instead of jQueryUI. To test, apply the patch and go to Reports -> Use saved. - On the Saved Reports page you should see multiple tabs. - Each should look correct and work correctly. - Clicking each tab should result in the table of reports filtering correctly for that tab (Patrons tab showing only patrons reports). - If necessary, edit one or more reports so that they have a subgroup. - Confirm that each subgroup selector is correct for each tab, i.e. a subgroup created under "Catalog" should only be available under the Catalog tab. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 133907 [details] [review] Bug 30491: Convert saved reports tabs to Bootstrap This patch updates the saved reports page so that it uses Bootstrap tabs instead of jQueryUI. To test, apply the patch and go to Reports -> Use saved. - On the Saved Reports page you should see multiple tabs. - Each should look correct and work correctly. - Clicking each tab should result in the table of reports filtering correctly for that tab (Patrons tab showing only patrons reports). - If necessary, edit one or more reports so that they have a subgroup. - Confirm that each subgroup selector is correct for each tab, i.e. a subgroup created under "Catalog" should only be available under the Catalog tab. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice work again, all works well in testing. Passing QA
Pushed to master for 22.05, thanks to everybody involved [U+1F984]