| Summary: | Add cancellation reason to holds delete endpoint | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Johanna Räisä <johanna.raisa> |
| Component: | REST API | Assignee: | Johanna Räisä <johanna.raisa> |
| Status: | Needs documenting --- | QA Contact: | Pedro Amorim <pedro.amorim> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, dcook, emmi.takkinen, lucas, pedro.amorim, tomascohen |
| Version: | Main | Keywords: | release-notes-needed |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 23269 | ||
| Attachments: |
Bug 30660: Add cancellation reason to holds delete endpoint
Bug 30660: Add cancellation reason to holds delete endpoint Bug 30660: Add cancellation reason to holds delete endpoint Bug 30660: Add cancellation reason to holds delete endpoint |
||
|
Description
Johanna Räisä
2022-05-02 07:14:02 UTC
Created attachment 139941 [details] [review] Bug 30660: Add cancellation reason to holds delete endpoint This patch adds cancellation reason to holds delete endpoint. Test plan: 1) prove t/db_dependent/api/v1/holds.t Sponsored-by: Koha-Suomi Oy The tests fail after applying the patch. There was quite a lot of output, so I'm just posting the last bit: ... Can't use an undefined value as a HASH reference at t/db_dependent/api/v1/holds.t line 252. # Looks like your test exited with 11 just after 3. t/db_dependent/api/v1/holds.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 14/14 subtests Test Summary Report ------------------- t/db_dependent/api/v1/holds.t (Wstat: 2816 Tests: 3 Failed: 3) Failed tests: 1-3 Non-zero exit status: 11 Parse errors: Bad plan. You planned 14 tests but ran 3. Files=1, Tests=3, 4 wallclock secs ( 0.01 usr 0.01 sys + 3.48 cusr 0.22 csys = 3.72 CPU) Result: FAIL Created attachment 170557 [details] [review] Bug 30660: Add cancellation reason to holds delete endpoint This patch adds cancellation reason to holds delete endpoint. Test plan: 1) prove t/db_dependent/api/v1/holds.t Sponsored-by: Koha-Suomi Oy Created attachment 170559 [details] [review] Bug 30660: Add cancellation reason to holds delete endpoint This patch adds cancellation reason to holds delete endpoint. Test plan: 1) prove t/db_dependent/api/v1/holds.t Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> Created attachment 173158 [details] [review] Bug 30660: Add cancellation reason to holds delete endpoint This patch adds cancellation reason to holds delete endpoint. Test plan: 1) prove t/db_dependent/api/v1/holds.t PA amended: tidy Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Pushed for 24.11! Well done everyone, thank you! Enhancement, no 24.05.x backport |